After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618438 - Remove icons from action items in the status menu
Remove icons from action items in the status menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-05-12 11:10 UTC by Sander Dijkhuis
Modified: 2010-05-12 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[panel] Remove icons from action items in the status menu (2.47 KB, patch)
2010-05-12 11:11 UTC, Sander Dijkhuis 		none Details | Review
[panel] PanelImageMenuItem should follow gtk-menu-show-images (4.10 KB, patch)
2010-05-12 15:46 UTC, Colin Walters 		committed Details | Review

Description Sander Dijkhuis 2010-05-12 11:10:29 UTC 
For consistency with the decision about menu icons in GNOME 2.28, it seems like a good idea to remove all icons from the status menu except for the status ones (available / busy / invisible). It also looks cleaner.

I'm not sure whether the icon references should be removed from the code completely, or they should listen to a GConf preference, but the following patch uses the first method.
Comment 1 Sander Dijkhuis 2010-05-12 11:11:55 UTC 
Created attachment 160889 [details] [review]
[panel] Remove icons from action items in the status menu

This is consistent with the change of icon usage in menus in GNOME 2.28 and it looks cleaner.
Comment 2 Florian Müllner 2010-05-12 13:15:30 UTC 
(In reply to comment #0)
> For consistency with the decision about menu icons in GNOME 2.28, it seems like
> a good idea to remove all icons from the status menu except for the status ones
> (available / busy / invisible). It also looks cleaner.

I agree with that - you should check with Colin and Jon about the motive for that change though.


> I'm not sure whether the icon references should be removed from the code
> completely, or they should listen to a GConf preference, but the following
> patch uses the first method.

I'd opt for a third possibility:
Do what GtkImageMenuItem does and add a "always-show-image" property to  PanelImageMenuItem and make it respect GtkSettings::gtk-menu-images if set to FALSE.

Hopefully this will also solve the problem of the labels with icons not being aligned with the ones without.
Comment 3 William Jon McCann 2010-05-12 14:33:14 UTC 
Looks good to me.
Comment 4 Colin Walters 2010-05-12 14:38:46 UTC 
(In reply to comment #2)
>
> 
> I'd opt for a third possibility:
> Do what GtkImageMenuItem does and add a "always-show-image" property to 
> PanelImageMenuItem and make it respect GtkSettings::gtk-menu-images if set to
> FALSE.

Patch for this coming up.
Comment 5 Colin Walters 2010-05-12 15:46:33 UTC 
Created attachment 160910 [details] [review]
[panel] PanelImageMenuItem should follow gtk-menu-show-images

Update statusMenu to always show images for the presence items only.
Comment 6 Florian Müllner 2010-05-12 18:32:44 UTC 
Review of attachment 160910 [details] [review]:

lgtm
Comment 7 Colin Walters 2010-05-12 21:26:36 UTC 
Attachment 160910 [details] pushed as e835cd2 - [panel] PanelImageMenuItem should follow gtk-menu-show-images