After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618349 - osxvideosink: implement the XOverlay interface
osxvideosink: implement the XOverlay interface
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Mac OS
: Normal normal
: 0.10.23
Assigned To: Alessandro Decina
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-11 09:06 UTC by Alessandro Decina
Modified: 2010-05-11 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (10.83 KB, patch)
2010-05-11 09:07 UTC, Alessandro Decina 		none Details | Review
patch (10.83 KB, patch)
2010-05-11 13:25 UTC, Alessandro Decina 		none Details | Review

Description Alessandro Decina 2010-05-11 09:06:19 UTC 
osxvideosink uses a custom bus message to notify the application about its internal NSView and give the application a chance to hook that up in the view hierarchy.

This patch implements the XOverlay interface keeping compatibility with the old method. Applications are supposed to pass a pointer to the superview in which they want to add the osxvideosink view in gst_x_overlay_set_xwindow_id.
Comment 1 Alessandro Decina 2010-05-11 09:07:20 UTC 
Created attachment 160806 [details] [review]
patch
Comment 2 Alessandro Decina 2010-05-11 13:25:47 UTC 
Created attachment 160818 [details] [review]
patch

New patch. Relaxed an assumption so that it doesn't break webkit (thanks Philippe for testing it).
Comment 3 Alessandro Decina 2010-05-11 18:14:33 UTC 
commit 5f9f71b38e886c41878577ba85c55a7c78e3abc9
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Tue May 11 10:52:58 2010 +0200

    osxvideosink: implement the xoverlay interface. Fixes #618349.