After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618303 - orca needs a custom script for eclipse
orca needs a custom script for eclipse
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.30.x
Other All
: Normal enhancement
: 2.32.0
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks: 575776
 
 
Reported: 2010-05-10 20:10 UTC by Jose Vilmar Estacio de Souza
Modified: 2010-09-20 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to create a script for eclipse (4.79 KB, patch)
2010-05-10 20:43 UTC, Jose Vilmar Estacio de Souza
committed Details | Review

Description Jose Vilmar Estacio de Souza 2010-05-10 20:10:17 UTC
When debugging a program in eclipse, Orca does not announce the line when a breakpoint is reached, despite a object:text-caret-moved
has been fired.

The default script used for the eclipse basically only generates output speech when that event happens if the Up/Down keys have been pressed.
Thus we must create a script for Eclipse and deal with different situations.
Comment 1 Jose Vilmar Estacio de Souza 2010-05-10 20:43:33 UTC
Created attachment 160770 [details] [review]
patch to create a script for eclipse
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-05-10 21:03:38 UTC
Review of attachment 160770 [details] [review]:

Looks good to me. Seems like a safe, isolated change. Pylints to a 10.0. Nothing to regression test. Therefore, I've committed it.

(And for the record, you were right: You did set the author info correctly. I committed it as-is and you showed up in as the author in the resulting commit.)

By the way, since we have other Eclipse users on the Orca list, it might be worth announcing the new script, the change you've made to speak the line at the breakpoint, and get folks to try it.

Very nice work, José!
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-05-10 21:05:17 UTC
Oh, one more thing José, it's your fix so you have the honor of closing it. <smile> Please set the status to RESOLVED and the resolution as FIXED.