GNOME Bugzilla – Bug 618285
Orca -q and --replace should quit gracefully using kill.
Last modified: 2010-09-20 10:52:53 UTC
At the moment we do 'kill -9' in orca.in (becomes orca.sh) This doesnt actually give us time to do graceful shutdown, we should be using 'kill' and if the user provides --force then we really know something has hung, and then we should use 'kill -9' for evidence see bug 591034#c14, comment 14, 15 and 16.
Created attachment 161207 [details] [review] Rev 1. Joanie, could you please check that this works ok on osol? The reason for lowering the debug level in gnomespeech.py: __speak, is that with gnome speech, we never say goodbye anyway, and having a traceback on command line is ugly. i am refering to Goodbye in orca.py:shutdown()
(In reply to comment #1) > Created an attachment (id=161207) [details] [review] > Rev 1. > > Joanie, could you please check that this works ok on osol? Seems to be. I've tried both regular quits and forced quits. I'm not noticing anything different, so I'm assuming it's fine. <smile>
Thanks! Same patch is commited to master.
Jon, any idea if something I'm seeing in the regression tests has anything to do with this fix? In particular, I now see for each test. Doesn't seem to impact the test results.... ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer ** (orca:22180): WARNING **: Failed to send buffer
Hi Joanie, Yes, they are from this one. Its because before we use to terminate orca, and now we are asking it nicely to quit. Its the gnome-speech that is causing this, and thats why i lowered it from severe to warning, but if you want the tests to run without having to modify the outputs, set the debug level in gnomespeech.py __speak() to none?
I just commented both of those lines out and I'm still seeing the warnings. Other ideas?