After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618041 - [everything] Fixes revealed by better parameter annotation
[everything] Fixes revealed by better parameter annotation
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-05-07 18:11 UTC by Owen Taylor
Modified: 2015-02-07 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[everything] Fixes revealed by better parameter annotation (4.03 KB, patch)
2010-05-07 18:11 UTC, Owen Taylor 		accepted-commit_now Details | Review
[everything] Fix length annotations (1.86 KB, patch)
2010-05-07 19:24 UTC, Owen Taylor 		committed Details | Review
[everything] Remove test_callback_infinite (2.89 KB, patch)
2010-05-07 19:26 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-05-07 18:11:07 UTC 
(length) annotation takes a parameter name not an index.
(scope infinite) was removed, so the test for it should be removed too.
Comment 1 Owen Taylor 2010-05-07 18:11:10 UTC 
Created attachment 160529 [details] [review]
[everything] Fixes revealed by better parameter annotation
Comment 2 Johan (not receiving bugmail) Dahlin 2010-05-07 18:12:02 UTC 
Review of attachment 160529 [details] [review]:

Would prefer two separate commits. But looks good.
Comment 3 Owen Taylor 2010-05-07 19:24:48 UTC 
Created attachment 160535 [details] [review]
[everything] Fix length annotations

Length annotations take a parameter name not a parameter index.
Comment 4 Owen Taylor 2010-05-07 19:26:12 UTC 
Created attachment 160536 [details] [review]
[everything] Remove test_callback_infinite

The 'infinite' value for callback scope was removed, so the test
case for it needs to be removed as well.
Comment 5 Owen Taylor 2010-05-07 19:27:51 UTC 
Attachment 160535 [details] pushed as fc43514 - [everything] Fix length annotations
Attachment 160536 [details] pushed as 52b0e7b - [everything] Remove test_callback_infinite
Comment 6 André Klapper 2015-02-07 16:44:28 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]