After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617914 - [PATCH] gtester-report: cope with binaries with no test cases
[PATCH] gtester-report: cope with binaries with no test cases
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-05-06 14:56 UTC by Robert Bragg
Modified: 2010-05-09 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtester-report: cope with binaries with no test cases (2.16 KB, patch)
2010-05-06 14:56 UTC, Robert Bragg 		accepted-commit_now Details | Review

Description Robert Bragg 2010-05-06 14:56:11 UTC 
Created attachment 160444 [details] [review]
gtester-report: cope with binaries with no test cases

It's possible that a given binary may conditionally decided not to run
any test cases (e.g. since they are all slow but -m=quick is currently
in use) In this case the xml may contain <testbinary> nodes with no
<testcase> children. This was resulting in a divide by zero when
calculating the green → red color interpolation.
Comment 1 Matthias Clasen 2010-05-09 00:05:59 UTC 
Comment on attachment 160444 [details] [review]
gtester-report: cope with binaries with no test cases

Looks good to me.
Comment 2 Robert Bragg 2010-05-09 19:32:34 UTC 
ok thanks; I've pushed to master as:

commit 03b5db44779c54947c3801609a42b2d2801b5a97
Author: Robert Bragg <robert@linux.intel.com>
Date:   Thu May 6 15:46:00 2010 +0100

    gtester-report: cope with binaries with no test cases
    
    It's possible that a given binary may conditionally decided not to run
    any test cases (e.g. since they are all slow but -m=quick is currently
    in use) In this case the xml may contain <testbinary> nodes with no
    <testcase> children. This was resulting in a divide by zero when
    calculating the green → red color interpolation.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=617914