After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617876 - Take into account the underscore after the type name when checking if a function is a method
Take into account the underscore after the type name when checking if a funct...
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 617880
 
 
Reported: 2010-05-06 09:43 UTC by Tomeu Vizoso
Modified: 2015-02-07 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Take into account the underscore after the type name when checking if a function is a method (2.92 KB, patch)
2010-05-06 09:43 UTC, Tomeu Vizoso 		none Details | Review
Take into account the underscore after the type name when checking if a function is a method (3.78 KB, patch)
2010-05-06 09:58 UTC, Tomeu Vizoso 		none Details | Review
Take into account the underscore after the type name when checking if a function is a method (3.78 KB, patch)
2010-05-19 16:02 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Tomeu Vizoso 2010-05-06 09:43:29 UTC 
Otherwise test_object_null_in (TestObj *obj) is considered to be a method called "ct_null_in"
of the class TestObj.
Comment 1 Tomeu Vizoso 2010-05-06 09:43:31 UTC 
Created attachment 160414 [details] [review]
Take into account the underscore after the type name when checking if a function is a method
Comment 2 Tomeu Vizoso 2010-05-06 09:58:06 UTC 
Created attachment 160419 [details] [review]
Take into account the underscore after the type name when checking if a function is a method
Comment 3 Tomeu Vizoso 2010-05-07 16:42:29 UTC 
jdahlin: the heuristics for matching function names (underscore style) to type names (GTypes) should be explained better
better comments in the source code would be appreciated as well

tomeu: maybe splitting that out to its own function

jdahlin: +1
Comment 4 Johan (not receiving bugmail) Dahlin 2010-05-19 16:02:03 UTC 
The following fix has been pushed:
2cfb577 Take into account the underscore after the type name when checking if a function is a method
Comment 5 Johan (not receiving bugmail) Dahlin 2010-05-19 16:02:10 UTC 
Created attachment 161466 [details] [review]
Take into account the underscore after the type name when checking if a function is a method
Comment 6 André Klapper 2015-02-07 17:01:42 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]