After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617748 - missing file in 2.31.1 tarball
missing file in 2.31.1 tarball
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
: 619539 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-05-05 12:35 UTC by Götz Waschk
Modified: 2010-06-08 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.01 KB, patch)
2010-05-15 00:07 UTC, William Jon McCann 		committed Details | Review

Description Götz Waschk 2010-05-05 12:35:34 UTC 
The gnome-settings-daemon 2.31.1 tarball release is missing plugins/smartcard/smartcard.gnome-settings-plugin

The build error is:

make: *** No rule to make target `smartcard.gnome-settings-plugin', needed by `all-am'.  Stop.
Comment 1 Ray Strode [halfline] 2010-05-05 18:16:02 UTC 
Should be all set:


commit 4b334ddf6c53ce795063d44746a9a2d90fea85ff
Author: Ray Strode <rstrode@redhat.com>
Date:   Wed May 5 14:14:00 2010 -0400

    Always dist smartcard.gnome-settings-plugin
    
    Before if the person who rolled the tarball lacked
    smartcard support on their system, then the build
    would break for someone with smartcard support enabled.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=617748
Comment 2 William Jon McCann 2010-05-15 00:07:38 UTC 
Created attachment 161103 [details] [review]
patch

The other fix seems to break building with --disable-smartcard-support
Comment 3 Ray Strode [halfline] 2010-05-24 18:29:48 UTC 
*** Bug 619539 has been marked as a duplicate of this bug. ***
Comment 4 David Ronis 2010-06-08 14:04:37 UTC 
I just tried to build 2.31.3.  Looks like the fix didn't make the tarball.
Comment 5 Ray Strode [halfline] 2010-06-08 22:02:28 UTC 
Comment on attachment 161103 [details] [review]
patch

Sorry, I missed the patch fly by in my bug mail.  Should be all set now:

Fix build for --disable-smartcard-supportmaster
commit 4b334ddf6c53ce795063d44746a9a2d90fea85ff broke the build for --disable-smartcard-users. This commit fixes that. Based on a patch from William Jon McCann <william.jon.mccann@gmail.com> https://bugzilla.gnome.org/show_bug.cgi?id=617748

Sorry about all the build goo issues.