GNOME Bugzilla – Bug 617747
Initial implementation of "Finding and Reminding"
Last modified: 2012-09-06 21:27:21 UTC
This bug covers an initial draft implementation of: http://live.gnome.org/GnomeShell/Design/Whiteboards/FindingAndReminding Some of the things we need to do: - Determine the set of items that belong in the "Desktop" based upon what's currently in Places and items tagged as "desktop" - Replace "Places" and "Recent Items" on the dash with "Desktop" - Add a more view that has the desktop items, a history of older items (fetched from tracker and other sources). Filing this bug so I can attach some crude bits of code to interact with Tracker.
Created attachment 160336 [details] [review] Move D-Bus utilities to a separate helper file To avoid duplicating code, move the D-Bus utilities from telepathy.js to a separate file dbusUtils.js.
Created attachment 160337 [details] [review] Initial stabs at some tracker code * Start putting some stuff in js/misc/tracker.js to interface with D-Bus * Add a test case that gets some data from tracker
Review of attachment 160336 [details] [review]: Can you add a comment on pathToName/nameToPath like: // There is no default association between DBus interface names and // object paths, but a number of services do name some of their // object paths as the obvious transformation of an interface name. // These functions are useful as a shorthand for those cases.
Review of attachment 160337 [details] [review]: ::: tests/interactive/tracker.js @@ +22,3 @@ +/* -*- mode: js2; js2-basic-offset: 4; indent-tabs-mode: nil -*- */ +function parseDateTime(s) { + var match = /(-?\d{4,})-(\d\d)-(\d\d)T(\d\d):(\d\d):(\d\d)(\.\d+)?(([+-])(\d\d):(\d\d)|Z)?/.exec(s); I'd prefer to see the regexp as a constant (and ideally with one or two sample strings it matches)
*** Bug 640674 has been marked as a duplicate of this bug. ***
Review of attachment 160337 [details] [review]: Rejected to get it off the ACN patch list. It's not going in now.
Finding and Reminding is in the domain of core apps now.