After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617331 - More warnings in -bad
More warnings in -bad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal trivial
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-30 21:19 UTC by LRN
Modified: 2010-04-30 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix some warnings in directdrawsink and directsoundsrc (2.34 KB, patch)
2010-04-30 21:20 UTC, LRN
committed Details | Review

Description LRN 2010-04-30 21:19:12 UTC
Apparently, directx-based plugins were disabled when i was scrubbing warnings off gst-plugins-bad.
Comment 1 LRN 2010-04-30 21:20:05 UTC
Created attachment 160015 [details] [review]
Fix some warnings in directdrawsink and directsoundsrc
Comment 2 Benjamin Otte (Company) 2010-04-30 22:06:49 UTC
commit baffaea6e85e704ba0b04e5fc88a6a488e0659c4
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Sat May 1 01:16:50 2010 +0400

    Fix warnings in directdrawsink and directsoundsrc
    
    Fixes #617331
Comment 3 Benjamin Otte (Company) 2010-04-30 22:12:33 UTC
Comment on attachment 160015 [details] [review]
Fix some warnings in directdrawsink and directsoundsrc

I modified the patch a bit to set action = NULL; only in the default handler and not in the initializer. The idea is that when you add new case statements and forget to set the action, you get warnings again with my patch, but not with yours.