After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617313 - Move documentation to inline comments: Gtk DND
Move documentation to inline comments: Gtk DND
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 599599
 
 
Reported: 2010-04-30 19:34 UTC by Garrett Regier
Modified: 2011-04-18 00:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move documentation to inline comments: Gtk DND (19.10 KB, patch)
2010-04-30 19:34 UTC, Garrett Regier
needs-work Details | Review

Description Garrett Regier 2010-04-30 19:34:51 UTC
Created attachment 159996 [details] [review]
Move documentation to inline comments: Gtk DND

Move documentation to inline comments for Gtk DND
Comment 1 Javier Jardón (IRC: jjardon) 2010-06-09 00:38:29 UTC
This problem has already fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Javier Jardón (IRC: jjardon) 2010-06-09 00:39:33 UTC
Ooops, sorry, wrong bug
Comment 3 Javier Jardón (IRC: jjardon) 2010-10-02 23:40:09 UTC
Review of attachment 159996 [details] [review]:

Could you rework the patch with the comments?

::: gtk/gtkdnd.c
@@ +982,3 @@
+ * @time_: a timestamp for retrieving the data. This will
+ *        generally be the time received in a "drag_data_motion"
+ *        or "drag_data_drop" signal.

Only 2 spaces for indentation, please

@@ +986,3 @@
+ * Gets the data associated with a drag. When the data
+ * is received or the retrieval fails, GTK+ will emit a
+ * "drag_data_received" signal. Failure of the retrieval

Use #GtkWidget::drag-data-received here

@@ +1062,3 @@
+ * @del: a flag indicating whether the source should delete the
+ *       original data. (This should be %TRUE for a move)
+ * @time_: the timestamp from the "drag_data_drop" signal.

Use #GtkWidget::drag-drop here

@@ +1168,3 @@
+ *
+ * Draws a highlight around a widget. This will attach
+ * handlers to  "expose_event" and "draw", so the highlight

Remove expose_event and use #GtkWidget::draw

::: gtk/gtkdnd.h
@@ +86,3 @@
+ * @GTK_TARGET_OTHER_APP:
+ *  If this is set, the target will not be selected
+ *  for drags within a single application. Since 2.12

As this will be applied in current master (future 3.0), the Since tag is not needed

@@ +89,3 @@
+ * @GTK_TARGET_OTHER_WIDGET:
+ *  If this is set, the target will not be selected
+ *  for drags withing a single widget. Since 2.12

Same here
Comment 4 Javier Jardón (IRC: jjardon) 2011-04-18 00:13:59 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.