Created attachment 163172 [details] [review]
[appDisplay] fix call nonexistent function 

WellGrid switched from StBin to StBoxLayout. set_child left in rarely
used code.

Review of attachment 163172 [details] [review]:

Looks good - just some minor comments here:

::: js/ui/appDisplay.js
@@ +1097,3 @@
         }
             this._grid.addItem(display.actor);
+        if (this._message) {

this._message should be initialized in _init()

@@ +1103,3 @@
         if (running.length == 0 && nFavorites == 0) {
 
+            this._message = new St.Label({ text: _("Drag here to add favorites") });

Not sure I like _message - _placeholderText maybe?

Created attachment 163186 [details] [review]
[appDisplay] fix call nonexistent function

Review of attachment 163186 [details] [review]:

Thanks! I'd suggest a commit message along the lines of:

[appDisplay] Fix crash when app well is empty

When the app well doesn't contain any applications, it displays a placeholder text
to indicate that it's a drop target. When porting WellGrid from St.Bin to St.BoxLayout,
the call to set_child() to set the text was overlooked.

Review of attachment 163186 [details] [review]:

Thanks! I'd suggest a commit message along the lines of:

[appDisplay] Fix crash when app well is empty

When the app well doesn't contain any applications, it displays a placeholder text
to indicate that it's a drop target. When porting WellGrid from St.Bin to St.BoxLayout,
the call to set_child() to set the text was overlooked.