After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617162 - Add override for Gdk.Color
Add override for Gdk.Color
Status: RESOLVED FIXED
Product: pygi
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: 0.6
Assigned To: pygi-maint
pygi-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-29 11:26 UTC by Tomeu Vizoso
Modified: 2010-04-30 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add override for Gdk.Color (1023 bytes, patch)
2010-04-29 11:26 UTC, Tomeu Vizoso 		reviewed Details | Review
Add override for Gdk.Color (1010 bytes, patch)
2010-04-29 16:33 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2010-04-29 11:26:29 UTC 
.
Comment 1 Tomeu Vizoso 2010-04-29 11:26:31 UTC 
Created attachment 159865 [details] [review]
Add override for Gdk.Color
Comment 2 Johan (not receiving bugmail) Dahlin 2010-04-29 11:34:59 UTC 
Review of attachment 159865 [details] [review]:

::: gi/overrides/Gdk.py
@@ +53,3 @@
+        self.b = b
+
+    def __new__(cls, *args, **kwargs):

are *args and **kwargs really needed?

@@ +62,3 @@
+
+
+__all__ = [Rectangle, Color]

the __all__ elements should be strings.
Comment 3 Tomeu Vizoso 2010-04-29 16:33:57 UTC 
Created attachment 159907 [details] [review]
Add override for Gdk.Color

Removes unneeded *args and **kwargs and puts strings in __all__.
Comment 4 johnp 2010-04-29 17:27:14 UTC 
Review of attachment 159907 [details] [review]:

the __all__ line is going to conflict with the commit I did this morning but otherwise this looks good.
Comment 5 Tomeu Vizoso 2010-04-30 13:06:10 UTC 
Attachment 159907 [details] pushed as 5657cca - Add override for Gdk.Color