After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617146 - Lots of printf string format warnings on Windows
Lots of printf string format warnings on Windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal trivial
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-29 00:53 UTC by LRN
Modified: 2010-04-29 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Massive fix for printf format strings (7.98 KB, patch)
2010-04-29 00:57 UTC, LRN 		committed Details | Review

Description LRN 2010-04-29 00:53:36 UTC 
MinGW GCC 4.5.0 doesn't give as much false positives as GCC 4.4.0 did, so i've removed -Wno-format and gave it a try. Core, -base, -good and -ugly got through without problems, but -bad got hit pretty hard.
Comment 1 LRN 2010-04-29 00:57:55 UTC 
Created attachment 159839 [details] [review]
Massive fix for printf format strings

Works for me. See if it gives any problems on other platforms.
Lack of understanding between GCC and %zu worries me, but as far as i've learned, it wouldn't work until the functions in question get marked by gnu_printf attribute. For now best thing i can come up with is to use GLib's equivalents (i hope that on Linux G_GSIZE_FORMAT evaluates to "zu" or something equally appropriate for size_t).
Comment 2 Benjamin Otte (Company) 2010-04-29 08:29:26 UTC 
commit 5f25780b02c34a479b143783f18d53a60dc03dbc
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Thu Apr 29 04:42:21 2010 +0400

    Fix printf format strings for gcc 4.5
    
    Done on Windows/MinGW.
    
    Fixes #617146