After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617140 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED OBSOLETE
Product: gnome-commander
Classification: Other
Component: application
1.4.x
Other Linux
: Normal normal
: 1.4
Assigned To: GNOME Commander maintainer(s)
epiotr
Depends on:
Blocks: 585391
 
 
Reported: 2010-04-28 23:31 UTC by André Klapper
Modified: 2018-08-03 18:00 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

Attachments
Partial patch (25.43 KB, patch)
2010-04-28 23:34 UTC, André Klapper 		committed Details | Review

Description André Klapper 2010-04-28 23:31:26 UTC 
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588339, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.
Comment 1 André Klapper 2010-04-28 23:34:45 UTC 
Created attachment 159836 [details] [review]
Partial patch

Partial patch fixing a few first issues.
Bumps gtk+ requirement to 2.14.
Feel free to commit if you're fine with it.

For all the GtkAllocation fixing I'd prefer to have gtk 2.18. Can the requirement be bumped or to you prefer staying with 2.14 and using instead
"#if GTK_CHECK_VERSION (2, x, y)" ?
Comment 2 André Klapper 2010-05-29 12:00:51 UTC 
ping - can this get a review?
Comment 3 epiotr 2010-05-30 20:43:42 UTC 
Thanks for your contribution. The patch has been committed to the repository and will go into the next, 1.2.9 release.

I've decided not to bump requirements for GTK+, just using instead `#if GTK_CHECK_VERSION(2,14,0)' where necessary
Comment 4 André Klapper 2010-06-01 07:54:26 UTC 
Reopening as it was a partial patch.
Comment 5 André Klapper 2010-12-29 23:46:58 UTC 
#if GTK_CHECK_VERSION stuff will make it extremely cumbersome. Adding a gtk-compat.h as other modules have done might be better.
Comment 6 epiotr 2010-12-30 20:24:39 UTC 
Agreed, it's not ideal, but usually other modules use gtk-compat.h to define '#if GTK_CHECK_VERSION' and practically it's the same. In gcmd case, it's much simpler this way and it'll be far easier to identify obsoleted part of code when switching to gtk-3.0
Comment 7 GNOME Infrastructure Team 2018-08-03 18:00:32 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-commander/issues/44.