After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617107 - Move invocation code to its own file
Move invocation code to its own file
Status: RESOLVED FIXED
Product: pygi
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: 0.6
Assigned To: pygi-maint
pygi-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-28 17:31 UTC by Tomeu Vizoso
Modified: 2010-05-03 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move invocation code to its own file (68.38 KB, patch)
2010-04-28 17:31 UTC, Tomeu Vizoso 		none Details | Review
Move invocation code to its own file (68.23 KB, patch)
2010-05-03 10:26 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2010-04-28 17:31:08 UTC 
.
Comment 1 Tomeu Vizoso 2010-04-28 17:31:11 UTC 
Created attachment 159813 [details] [review]
Move invocation code to its own file
Comment 2 Zach Goldberg 2010-04-28 17:50:08 UTC 
Review of attachment 159813 [details] [review]:

Looks good.

::: gi/pygi-callbacks.h
@@ +22,2 @@
 #define __PYGI_CALLBACKS_H__
+#include "pygi-closure.h"

Is this change needed?  Isn't pygi-closure.c imported in pygi.h?
Comment 3 Tomeu Vizoso 2010-04-28 17:52:25 UTC 
(In reply to comment #2)
> Review of attachment 159813 [details] [review]:
> 
> Looks good.
> 
> ::: gi/pygi-callbacks.h
> @@ +22,2 @@
>  #define __PYGI_CALLBACKS_H__
> +#include "pygi-closure.h"
> 
> Is this change needed?  Isn't pygi-closure.c imported in pygi.h?

Well, but pygi-callbacks.h didn't import anything.
Comment 4 Zach Goldberg 2010-04-30 16:30:45 UTC 
Is that a problem?
Comment 5 Tomeu Vizoso 2010-05-03 10:26:12 UTC 
Created attachment 160185 [details] [review]
Move invocation code to its own file

You are right, it wasn't needed.
Comment 6 Zach Goldberg 2010-05-03 16:24:25 UTC 
Review of attachment 160185 [details] [review]:

Fine with me!
Comment 7 Tomeu Vizoso 2010-05-03 16:25:56 UTC 
Attachment 160185 [details] pushed as 9669acd - Move invocation code to its own file