Bug 616890 - Indicate when best fit and normal zoom are true
Indicate when best fit and normal zoom are true
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.30.x
Other Linux
: Normal enhancement
: GNOME3.0
Assigned To: EOG Maintainers
EOG Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-04-26 21:37 UTC by Allan Day
Modified: 2010-10-20 09:35 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Allan Day 2010-04-26 21:37:28 UTC 
Best fit and Normal Zoom are states. The toolbar buttons and menu buttons which control these should provide feedback about when they are true: the appropriate toolbar buttons should appear depressed; the relevant menu items should have check boxes next to them (like Evince does).

This change will make EoG's user interface more usable, since it will (in some situations) prevent users being confused about the current zoom level. It will also teach users about the default zoom level and how to return to it.
Comment 1 Felix Riemann 2010-10-17 12:00:47 UTC 
Implemented this for "Best Fit" (Shrink to Fit) now but left out normal zoom. Normal zoom doesn't change the zooming behaviour as "best fit" does. It's more a bookmark/shortcut for a fixed zoom factor of 1.0. Also they can happen both at the same time which could be confusing again.

commit 05810eafb4781b3313f59e2e52724d6ea4ede118
Author: Felix Riemann <>
Date:   Sun Oct 17 13:06:58 2010 +0200

    Make "Best Fit" a toggle action
    
    This should make it clear from the toolbar when the image will be
    rescaled with the window and when not. Fixes bug 616890.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Allan Day 2010-10-20 09:35:20 UTC 
Great stuff! :)
Note You need to log in before you can comment on or make changes to this bug.