Bug 616743 - Use positional sound for audible window bell
Use positional sound for audible window bell
Status: NEW
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal enhancement
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-04-25 01:01 UTC by Dylan McCall
Modified: 2010-05-03 08:58 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (based on metacity from git) adding positional sound hints to src/core/bell.c: meta_bell_notify (2.22 KB, patch)
2010-04-25 01:02 UTC, Dylan McCall
none Details | Diff | Review

Description Dylan McCall 2010-04-25 01:01:39 UTC
Many components in the GNOME desktop use libcanberra-gtk to play sounds, which has led us to a wonderful world of positional sounds (in many cases), where a sound seems to come from the same direction as an interaction on the screen.

Metacity uses libcanberra for audible bells, so it is pretty straight-forward to get the same feature. In my opinion, it would make Metacity's bell sound suddenly awesome, for a number of reasons.

To implement the feature, Metacity needs to give a few extra properties to Canberra, which describe the position of the window associated with the bell.

Patch is attached. I look forward to any feedback!
Some usability analysis may be a good idea, too. I think positional sounds have tremendous benefits for usability, but there could be some other viewpoints out there :)
Comment 1 Dylan McCall 2010-04-25 01:02:01 UTC
Created attachment 159494 [details] [review]
Patch (based on metacity from git) adding positional sound hints to src/core/bell.c: meta_bell_notify
Comment 2 Thomas Thurman 2010-05-02 15:14:08 UTC
Review of attachment 159494 [details] [review]:

Doesn't this introduce a memory leak when you remove the calls to g_free() and friends?
Comment 3 Thomas Thurman 2010-05-02 15:28:12 UTC
Review of attachment 159494 [details] [review]:

Sorry, ignore that.  It was supposed to be added to a completely different bug.

Note You need to log in before you can comment on or make changes to this bug.