After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616732 - PyGi should not depend on Cairo
PyGi should not depend on Cairo
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-24 20:40 UTC by Zach Goldberg
Modified: 2010-08-16 08:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make Cairo an optional dependency (2.59 KB, patch)
2010-08-12 14:20 UTC, Simon van der Linden
committed Details | Review

Description Zach Goldberg 2010-04-24 20:40:13 UTC
If cairo is found missing in ./configure then we should simply not compile the cairo pieces of pygi.  Right now if cairo is missing the build fails.
Comment 1 Johan (not receiving bugmail) Dahlin 2010-04-24 22:00:57 UTC
configure should fail if cairo isn't fosund, as it is an excepted dependency.
Comment 2 Zach Goldberg 2010-04-24 22:10:33 UTC
I would much prefer if we simply didn't build the cairo piece of pygi if cairo is not found.  Cairo is not needed for many applications of PyGi and as such there should be no need to have a hard dependency.
Comment 3 Tomeu Vizoso 2010-04-26 08:28:02 UTC
(In reply to comment #2)
> I would much prefer if we simply didn't build the cairo piece of pygi if cairo
> is not found.  Cairo is not needed for many applications of PyGi and as such
> there should be no need to have a hard dependency.

In that case, I would add a --disable-cairo config switch, because otherwise I'm sure we'll see some distros shipping a cairo-disabled pygi just because they didn't add cairo to their build depends.
Comment 4 Zach Goldberg 2010-04-26 16:26:46 UTC
I like this idea a lot.  So there are two patches here:

1) Add a flag for --disable-cairo which a) skips the configure check for cairo (or makes it non-fatal) and b) prevents the cairo code from being built

2) without --disable-cairo pygi ./configure should not pass if cairo is missing
Comment 5 Simon van der Linden 2010-08-12 14:20:35 UTC
Created attachment 167733 [details] [review]
Make Cairo an optional dependency

Add the --enable-cairo configure argument.
Comment 6 Tomeu Vizoso 2010-08-16 08:05:33 UTC
Thanks!

Attachment 167733 [details] pushed as 65a06a7 - Make Cairo an optional dependency