GNOME Bugzilla – Bug 616732
PyGi should not depend on Cairo
Last modified: 2010-08-16 08:05:36 UTC
If cairo is found missing in ./configure then we should simply not compile the cairo pieces of pygi. Right now if cairo is missing the build fails.
configure should fail if cairo isn't fosund, as it is an excepted dependency.
I would much prefer if we simply didn't build the cairo piece of pygi if cairo is not found. Cairo is not needed for many applications of PyGi and as such there should be no need to have a hard dependency.
(In reply to comment #2) > I would much prefer if we simply didn't build the cairo piece of pygi if cairo > is not found. Cairo is not needed for many applications of PyGi and as such > there should be no need to have a hard dependency. In that case, I would add a --disable-cairo config switch, because otherwise I'm sure we'll see some distros shipping a cairo-disabled pygi just because they didn't add cairo to their build depends.
I like this idea a lot. So there are two patches here: 1) Add a flag for --disable-cairo which a) skips the configure check for cairo (or makes it non-fatal) and b) prevents the cairo code from being built 2) without --disable-cairo pygi ./configure should not pass if cairo is missing
Created attachment 167733 [details] [review] Make Cairo an optional dependency Add the --enable-cairo configure argument.
Thanks! Attachment 167733 [details] pushed as 65a06a7 - Make Cairo an optional dependency