After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616710 - [Hyena.Data] Handle bad indices in MemoryListModel
[Hyena.Data] Handle bad indices in MemoryListModel
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-24 15:43 UTC by Ruben Vermeersch
Modified: 2010-04-25 08:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[Hyena.Data] Handle bad indices in MemoryListModel (1.14 KB, patch)
2010-04-24 15:43 UTC, Ruben Vermeersch 		committed Details | Review

Description Ruben Vermeersch 2010-04-24 15:43:04 UTC 
Makes sure that MemoryListModel returns correct values when bad indices are
given. This makes it compatible with how Banshee's MemoryListModel works.

Without this, grid view crashes.
Comment 1 Ruben Vermeersch 2010-04-24 15:43:07 UTC 
Created attachment 159475 [details] [review]
[Hyena.Data] Handle bad indices in MemoryListModel
Comment 2 Ruben Vermeersch 2010-04-24 15:45:32 UTC 
The crash I'm referring to here happens when you use the Hyena MemoryListModel. Banshee does not use this one and as such is not impacted by this crash.

Patch originally by Mike.
Comment 3 Alexander Kojevnikov 2010-04-25 01:34:09 UTC 
Review of attachment 159475 [details] [review]:

Please add braces for the `if`, other than that the patch looks good.
Comment 4 Ruben Vermeersch 2010-04-25 08:56:53 UTC 
Comment on attachment 159475 [details] [review]
[Hyena.Data] Handle bad indices in MemoryListModel

Committed with the mentioned changes, thanks for the quick review!

http://git.gnome.org/browse/banshee/commit/?id=185d4a769dcf5446c9ba3138b49008a62ed42998