After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616700 - [rtspsrc] gst_query_new_seeking() fails on rtspsrc
[rtspsrc] gst_query_new_seeking() fails on rtspsrc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-24 11:53 UTC by hmspider
Modified: 2010-05-11 09:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implement seeking query (1.05 KB, patch)
2010-05-04 14:00 UTC, Alessandro Decina 		committed Details | Review

Description hmspider 2010-04-24 11:53:06 UTC 
- seeking controls don't work
- seeking with timebar doesn't work
- clip url: http://www.seminars.apple.com/seminarsonline/managing/us-media/managing_600.mov

totem version 2.30.0, OS ubuntu Lucid
Comment 1 Bastien Nocera 2010-05-04 10:15:46 UTC 
The "clip" is actually just a redirect to an RTSP source. Not sure why we can't seek it in...

 45149 0:00:04.212544203 ^[[335m15742^[[00m       0xc38130 ^[[36mDEBUG  ^[[00m ^[[00m               totem bacon-video-widget-gst-0.10.c:1465:bvw_handle_element_message:^[[00m Got redirect to 'rtsp://a435.q.kamai.net/3/435/49/4a00d17b/1a1a1a9e0d83ec51c4f263d74d7bdc4cbc288dbb1e8d       fa2996057be449bceb5bcd3c6bd03eb21789f96bd447ac1f80ec51c4/entmanagingwmad_600.mov'•

The seek example in gst-plugins-base can seek in the file, but not Totem.
Comment 2 Bastien Nocera 2010-05-04 11:59:11 UTC 
rtspsrc doesn't actually ever tell us whether a stream is seekable.
Comment 3 Alessandro Decina 2010-05-04 14:00:40 UTC 
Created attachment 160262 [details] [review]
Implement seeking query
Comment 4 Bastien Nocera 2010-05-04 14:04:31 UTC 
Review of attachment 160262 [details] [review]:

Looks good to me apart from that style niggle.

::: gst/rtsp/gstrtspsrc.c
@@ +1891,3 @@
+      gst_query_parse_seeking (query, &format, NULL, NULL, NULL);
+      if (format == GST_FORMAT_TIME) {
+        gboolean seekable = src->cur_protocols != GST_RTSP_LOWER_TRANS_UDP_MCAST;

brackets around the condition
Comment 5 Alessandro Decina 2010-05-04 14:15:25 UTC 
commit c8a02a91a6418fab7dadf5de819b0b3d65f832b1
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Tue May 4 16:04:39 2010 +0200

    rtspsrc: handle SEEKING queries.