After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616660 - empathy-accounts g-c-c module needs to setup l10n
empathy-accounts g-c-c module needs to setup l10n
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-23 15:19 UTC by Rob Bradford
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.57 KB, patch)
2010-04-23 15:52 UTC, Rob Bradford 		none Details | Review
Working patch (1.57 KB, patch)
2010-04-23 15:55 UTC, Rob Bradford 		none Details | Review
Version that sets up gettext on module load (1.57 KB, patch)
2010-04-26 11:15 UTC, Rob Bradford 		none Details | Review

Description Rob Bradford 2010-04-23 15:19:14 UTC 
We need to make the g-c-c process also load in the empathy translations for this module.
Comment 1 Rob Bradford 2010-04-23 15:52:04 UTC 
Created attachment 159442 [details] [review]
Proposed patch
Comment 2 Rob Bradford 2010-04-23 15:55:04 UTC 
Created attachment 159445 [details] [review]
Working patch

Here, have a version that will build ;-)
Comment 3 Rob Bradford 2010-04-23 17:13:42 UTC 
Although apparently this solution is wrong since you need do something special because it's a shared library.
Comment 4 Guillaume Desmottes 2010-04-26 08:54:43 UTC 
I asked to few people and it seems that lib are not supposed to call textdomain().

Could you test with this branch please?
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/trad-616660

Also, maybe this code should be moved to _class_init() rather than _init()?
Comment 5 Rob Bradford 2010-04-26 11:15:19 UTC 
Created attachment 159586 [details] [review]
Version that sets up gettext on module load

Yeh, you're right you're not supposed to do that and in fact a nicer place is in the module load... which is where we're doing it for other modules (see attached patch)
Comment 6 Guillaume Desmottes 2010-04-26 11:20:20 UTC 
Looks good. Please merge to master and gnome-2.30 (I'll release 2.30.1 today).
Comment 7 Guillaume Desmottes 2010-04-26 14:01:00 UTC 
I merged it myself as I'm about to release 2.30.1.
Thanks for the fix!

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 8 Rob Bradford 2010-04-26 15:08:49 UTC 
Coolio always a pleasure Guillaume! :-)