After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616658 - alarm / systray busted ...
alarm / systray busted ...
Status: RESOLVED OBSOLETE
Product: evolution
Classification: Applications
Component: Calendar
2.30.x (obsolete)
Other Linux
: Normal critical
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
evolution[gnome3]
Depends on:
Blocks:
 
 
Reported: 2010-04-23 15:11 UTC by Michael Meeks
Modified: 2017-08-31 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Meeks 2010-04-23 15:11:09 UTC
The setting "notify_with_tray" is being clobbered on every alarm daemon start. That is painful for two reasons: it dumps crud in ~/.gconf that we don't need, and it also turns this setting on un-conditionally on start [ which is exposed in the GUI, and we might want turned off - eg. for MeeGo which has no systray ].

So: from calendar/gui/alarm-notify/config-data.c:

state = gconf_client_get_bool (conf_client,
		      "/apps/evolution/calendar/notify/notify_with_tray",
		      NULL);
if (!state) /* Should be old client*/ {
	GSList *source;
	gconf_client_set_bool (conf_client,
		      "/apps/evolution/calendar/notify/notify_with_tray",
		      TRUE,
		      NULL);
	source = gconf_client_get_list (conf_client,
				"/apps/evolution/calendar/sources",
				GCONF_VALUE_STRING,
				NULL);
	gconf_client_set_list (conf_client,
			       key,
			       GCONF_VALUE_STRING,
			       source,
			       NULL);

So - we just set that boolean to TRUE if it is not set ? why ?

Were we really just trying to detect that that key was not set ? And since that code dates back to oh - 2007 or before; can we just cut it out ? :-)

Failing that, could we make it actually check for the key's non-existence rather than whether it is set to false ? I believe that can be done with gconf_client_get_without_default() - or something ?

Thanks. [ I've patched this out for MeeGo ].
Comment 1 Milan Crha 2010-09-30 14:38:02 UTC
Please commit your MeeGo patch to master and gnome-2-32. Thanks in advance.

I suppose it removes that "set to TRUE if off", which, I agree, shouldn't be there.
Comment 2 Milan Crha 2017-08-31 12:11:09 UTC
This is gone with the move to GSettings.