After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616648 - Change AM_GSETTINGS macro to GLIB_GSETTINGS
Change AM_GSETTINGS macro to GLIB_GSETTINGS
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-04-23 13:43 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-04-23 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change AM_GSETTINGS macro to GLIB_GSETTINGS (2.03 KB, patch)
2010-04-23 13:44 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-04-23 13:43:35 UTC 
So we don't use Automake's macro namespace

Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-23 13:44:34 UTC 
Created attachment 159426 [details] [review]
Change AM_GSETTINGS macro to GLIB_GSETTINGS
Comment 2 Matthias Clasen 2010-04-23 14:35:14 UTC 
Comment on attachment 159426 [details] [review]
Change AM_GSETTINGS macro to GLIB_GSETTINGS

Would be nice if you could also take care of Behdads other complaints.
Comment 3 Christian Dywan 2010-04-23 15:05:22 UTC 
> +dnl deprecated macro
> +AU_ALIAS([AM_GSETTINGS], [GLIB_GSETTINGS])

I think we shouldn't alias that, otherwise people might mistakenly continue to use it and not notice.
Comment 4 Matthias Clasen 2010-04-23 15:32:42 UTC 
Oh, didn't catch that. Right. No alias please. This stuff was not in a stable release.
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-23 15:38:32 UTC 
Comment on attachment 159426 [details] [review]
Change AM_GSETTINGS macro to GLIB_GSETTINGS

committed with your comments (no alias)

commit f68dc4d97d7aeaa8588a4ea0d36f057cd5aaf42e
Comment 6 Javier Jardón (IRC: jjardon) 2010-04-23 15:39:33 UTC 
I think we can close this by now, Behdad improvements can be added later in another bug report.