After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616638 - Ellipsize long subjects
Ellipsize long subjects
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-23 12:03 UTC by Robin Stocker
Modified: 2010-05-29 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ellipsize long subjects in revision view (1011 bytes, patch)
2010-04-23 12:05 UTC, Robin Stocker 		none Details | Review

Description Robin Stocker 2010-04-23 12:03:32 UTC 
In repositories converted from CVS or SVN, it may be that a subject line is really long, because it was written as a multi-line comment (not adhering to the Git style guide).

When clicking on such a commit, gitg's window is resized to a really big size. This is because it wants to show the whole subject line in the details. As long as the commit is selected, it isn't possible to make the window smaller again.

Therefore, it is probably a good idea to ellipsize the subject line, see patch.
Comment 1 Robin Stocker 2010-04-23 12:05:45 UTC 
Created attachment 159420 [details] [review]
Ellipsize long subjects in revision view
Comment 2 jessevdk@gmail.com 2010-05-29 11:32:16 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Robin Stocker 2010-05-29 17:05:34 UTC 
Thanks! The parents commit message is also ellipsized, but it uses PANGO_ELLIPSIZE_MIDDLE (in gitg-revision-view.c). Should we change that to PANGO_ELLIPSIZE_END to have the same behaviour as the subject?
Comment 4 jessevdk@gmail.com 2010-05-29 19:33:16 UTC 
You're probably right it's better to be consistent. I've changed it to 'end' too.