GNOME Bugzilla – Bug 616510
Show a border around images
Last modified: 2015-08-28 19:10:18 UTC
EoG currently fits the image right up to the edges of the viewing area. This is not the best for viewing purposes. Having the background colour surround the image in order to frame it will enable the picture to be viewed more easily. This is what happens when images are physically framed - a mount is used to surround the image in order to achieve maximum viewing pleasure. :) I've attached a mockup to demonstrate what I mean.
Created attachment 165808 [details] [review] [ZoomToFit] Add a border around images The current zoom-to-fit behavior is to fit the image exactly into the viewing area - while this maximizes the use of screen real estate, the image looks a lot more balanced when leaving a small frame around it. Add a (hidden) configuration option to set the maximum fraction of the content area the image should cover, with a default value of 0.9 (e.g. leaving a minimum of 5% of the viewing area around each edge). This implements a design proposal from Allan Day. (In reply to comment #0) > I've attached a mockup to demonstrate what I mean. No, you didn't ;-) Seriously, I'm no designer/usability guru/.., so while I understand your reasoning, I still had to pull a default minimum frame width out of *ehem* somewhere. So in addition to the code review a quick ui review would be appreciated as well ...
(In reply to comment #1) > This implements a design proposal from Allan Day. Yay! > (In reply to comment #0) > > I've attached a mockup to demonstrate what I mean. > > No, you didn't ;-) Ha, apologies. I'll rectify that. > Seriously, I'm no designer/usability guru/.., so while I understand your > reasoning, I still had to pull a default minimum frame width out of *ehem* > somewhere. So in addition to the code review a quick ui review would be > appreciated as well ... I used a minimum frame width of 30 pixels for the mockups, but I didn't consider different viewing area sizes. Your approach will suit smaller viewing areas better. Hylke: have you got an opinion on this? I'll do my best to review this, though it may have to wait a while.
Created attachment 165813 [details] Mockup showing an image border
I think a multiple of 6px as specified by the HIG is fine.
This only works when set to fit the image. Allan, is that really what you wanted? Feels a bit strange to me that way.
(In reply to comment #5) > This only works when set to fit the image. > Allan, is that really what you wanted? Feels a bit strange to me that way. The image should always have a border round it, even when zoomed in. This is why I suggested using a hand cursor to pan (as described in bug 491851).
I think this is obsolete by now, as we're going the "as-much-space-as-possible-for-the-image" route at the moment.