After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616405 - gsettings missing g_return_if_fail's
gsettings missing g_return_if_fail's
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-04-21 14:54 UTC by Christian Persch
Modified: 2010-04-22 01:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add g_return_if_fail guards (2.93 KB, patch)
2010-04-21 18:07 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Christian Persch 2010-04-21 14:54:32 UTC
The public GSettings functions are missing the usual parameter checks.
Comment 1 Matthias Clasen 2010-04-21 15:59:25 UTC
If you have a patch...
Comment 2 Javier Jardón (IRC: jjardon) 2010-04-21 18:07:49 UTC
Created attachment 159274 [details] [review]
Add g_return_if_fail guards
Comment 3 Matthias Clasen 2010-04-22 00:38:41 UTC
Comment on attachment 159274 [details] [review]
Add g_return_if_fail guards

Looks ok
Comment 4 Javier Jardón (IRC: jjardon) 2010-04-22 01:11:37 UTC
Comment on attachment 159274 [details] [review]
Add g_return_if_fail guards

commit 0fa791b29d4b3aa2154f322dda5a7c0d2caa1ede
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-22 01:11:47 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.