After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616339 - Problem with & symbol from status messages links in tooltips.
Problem with & symbol from status messages links in tooltips.
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-20 21:03 UTC by Krzysztof Klinikowski
Modified: 2010-11-02 09:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
image (103.88 KB, image/png)
2010-04-20 21:03 UTC, Krzysztof Klinikowski 		  Details
proposed fix (1.12 KB, patch)
2010-09-28 14:45 UTC, Vitaly Minko 		none Details | Review

Description Krzysztof Klinikowski 2010-04-20 21:03:57 UTC 
Created attachment 159197 [details]
image

A simple problem. When someone have status like link with & character and you mouse over on his contact and Empathy shows you tooltip you see that bug. Telepathy debugger shows me:

 Failed to set text from markup due to error parsing markup: Błąd w wierszu 1: Jednostka nie jest zakończona średnikiem; najprawdopodobniej został użyty znak &, który nie miał oznaczać jednostki - należy go zapisać jako &

 it means that I should replace & as & :>
Comment 1 Vitaly Minko 2010-09-28 14:45:10 UTC 
Created attachment 171266 [details] [review]
proposed fix

We need to escape URL itself along with the Title.
Comment 2 Vitaly Minko 2010-10-28 13:28:40 UTC 
Ping
Comment 3 Xavier Claessens 2010-10-28 14:14:20 UTC 
I don't think that's a good idea to escape the URL itself, will it still be working in all cases (I mean, if I click on it, the correct URL opens)?

For the record, the Russian(?) error message in bug report is this one in English:
Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &

This looks like a GtkLabel error to me, the href part of a <a> tag should not be forced to respect markups, since it's not displayed...
Comment 4 Xavier Claessens 2010-10-28 14:22:42 UTC 
Hm, asking gtk devs, it seems you are right, escaping the href part is safe. Could you please verify that when clicking such link, the &amp; is correctly un-escaped and opens correctly in the browser, though.
Comment 5 Vitaly Minko 2010-11-01 13:02:28 UTC 
>Could you please verify that when clicking such link, the &amp; is correctly
un-escaped and opens correctly in the browser, though.

Checked, &amp is unescaped properly.
Comment 6 Xavier Claessens 2010-11-02 08:52:44 UTC 
Ok then, you can merge :)

Thanks for your contribution!
Comment 7 Guillaume Desmottes 2010-11-02 09:08:51 UTC 
Merged; thanks!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.