After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616312 - Add m4 rule equivalent to GCONF_SCHEMAS_INSTALL
Add m4 rule equivalent to GCONF_SCHEMAS_INSTALL
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-04-20 16:30 UTC by Bastien Nocera
Modified: 2010-04-21 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow passing multiple schemas to gschema-compile (1.97 KB, patch)
2010-04-21 11:26 UTC, Bastien Nocera
none Details | Review
Add GSettings macros helper (2.23 KB, patch)
2010-04-21 11:26 UTC, Bastien Nocera
none Details | Review
Allow passing multiple schemas to gschema-compile (2.68 KB, patch)
2010-04-21 12:09 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2010-04-20 16:30:17 UTC
So that packagers can do the installation in post-installation scripts, as opposed to when installing the binaries and data files into a prefix.
Comment 1 Allison Karlitskaya (desrt) 2010-04-20 21:34:07 UTC
i was thinking of doing this but i don't know my m4.

would be nice if it automatically looked for the path of the gschema-compiler in the pkgconfig file, etc.

any support should also include a rule that attempts to build the schema file in the 'make all' rule before 'make install' installs a potentially broken file.
Comment 2 Matthias Clasen 2010-04-20 23:30:04 UTC
The --one-schema-file and --dry-run options in that other bug could be very useful for that 'attempt to build'
Comment 3 Matthias Clasen 2010-04-21 04:27:55 UTC
I've committed support for --one-schema-file and --dry-run now
Comment 4 Bastien Nocera 2010-04-21 11:26:07 UTC
Created attachment 159245 [details] [review]
Allow passing multiple schemas to gschema-compile

To make test suites easier to implement
Comment 5 Bastien Nocera 2010-04-21 11:26:20 UTC
Created attachment 159246 [details] [review]
Add GSettings macros helper
Comment 6 Bastien Nocera 2010-04-21 11:28:18 UTC
When those 2 patches get in, I'll modify the porting guide to take that into account.
Comment 7 Christian Persch 2010-04-21 11:44:05 UTC
-  if (one_schema_file)
+  if (schema_files)
     {
-      g_ptr_array_add (files, one_schema_file);
+      guint i;
+      for (i = 0; i < g_strv_length (schema_files); i++)
+        g_ptr_array_add (files, schema_files[i]);
     }

That seems redundant, since schema_files is already a NULL-terminated array...
You could just use build the ptrarray only in the !schema_files case, and assign schema_files = g_ptr_array_free (files, FALSE), and then use that instead of |files->pdata| in the parse_gschema_files call.
Comment 8 Bastien Nocera 2010-04-21 12:09:38 UTC
Created attachment 159248 [details] [review]
Allow passing multiple schemas to gschema-compile

To make test suites easier to implement
Comment 9 Matthias Clasen 2010-04-21 13:27:29 UTC
Comment on attachment 159248 [details] [review]
Allow passing multiple schemas to gschema-compile

Please commit
Comment 10 Bastien Nocera 2010-04-21 15:20:07 UTC
Comment on attachment 159246 [details] [review]
Add GSettings macros helper

Committed a slightly different version with recent pkg-config changes
Comment 11 Bastien Nocera 2010-04-21 15:50:06 UTC
Porting guide updated as well. All done!