GNOME Bugzilla – Bug 616222
libgdata fails to build from a remote directory
Last modified: 2010-04-23 13:15:32 UTC
Created attachment 159112 [details] [review] Patch to fix "remote" build errors in libgdata When trying to compile libgdata from a directory outside the source directory, I get multiple failures. Please see the attached patch for solutions. FYI, there's an autoconf-provided target "make distcheck" which will create a distribution tarball, then untar it in a temporary directory, then try to configure and build it from a remote directory, all in one go. If you use that to create your release tarball instead of just "make dist", you can be pretty confident it will build properly. Cheers!
(In reply to comment #0) > Created an attachment (id=159112) [details] [review] > Patch to fix "remote" build errors in libgdata > > When trying to compile libgdata from a directory outside the source directory, > I get multiple failures. Please see the attached patch for solutions. Looks good. Please commit, but either re-order the lines in gdata_libgdata_la_CPPFLAGS or change the comment so that the comment above it still applies. > FYI, there's an autoconf-provided target "make distcheck" which will create a > distribution tarball, then untar it in a temporary directory, then try to > configure and build it from a remote directory, all in one go. If you use that > to create your release tarball instead of just "make dist", you can be pretty > confident it will build properly. I do use make distcheck, but master has seen a lot of churn without any releases for a while, so I expect that's where the breakage has crept in.
I don't believe I have commit privileges...? I can provide another patch with appropriate comments etc. Just FYI, I did switch back to the libgdata-0-6 branch and saw the same issue; maybe the problem appears there as well?
Committed to libgdata-0-6 and master. Thanks a lot. commit 4468035a9fab71253d66bf50234d9ca50cb3328a Author: Paul Smith <psmith@gnu.org> Date: Fri Apr 23 14:13:09 2010 +0100 Bug 616222 — libgdata fails to build from a remote directory Be more strict in our use of top_[srcdir|builddir]. Closes: bgo#616222 Makefile.am | 22 +++++++++++++--------- 1 files changed, 13 insertions(+), 9 deletions(-)