After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616198 - gvfs-gdu-volume-monitor exits when plugging removable media on non UTF-8 system
gvfs-gdu-volume-monitor exits when plugging removable media on non UTF-8 system
Status: RESOLVED OBSOLETE
Product: gnome-disk-utility
Classification: Core
Component: libgdu
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-19 16:46 UTC by Pascal Terjan
Modified: 2012-11-12 21:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Possible fix (1.02 KB, patch)
2010-05-03 12:07 UTC, Pascal Terjan
none Details | Review

Description Pascal Terjan 2010-04-19 16:46:40 UTC
I own some usb keys formatted as FAT but without partition table

They do not get mounted and dbus-daemon and udisks-daemon sometimes use 100% cpu, and some app loop displaying warning until I remove the key:

(emacs-23-1:18551): GVFS-RemoteVolumeMonitor-WARNING **: New owner :1.6204 for volume monitor org.gtk.Private.GduVolumeMonitor connected to the bus; seeding drives/volumes/mounts

(emacs-23-1:18551): GVFS-RemoteVolumeMonitor-WARNING **: invoking List() failed for type GProxyVolumeMonitorGdu: org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus)

(emacs-23-1:18551): GVFS-RemoteVolumeMonitor-WARNING **: New owner :1.6206 for volume monitor org.gtk.Private.GduVolumeMonitor connected to the bus; seeding drives/volumes/mounts

(emacs-23-1:18551): GVFS-RemoteVolumeMonitor-WARNING **: invoking List() failed for type GProxyVolumeMonitorGdu: org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus)

I noticed once that gvfs-gdu-volume-monitor had segfaulted on unplug but all the other times it just exits with code 1 when I start nautilus if the key is plugged in.

[pterjan@plop injection]$ gvfs-mount --monitor
Monitoring events. Press Ctrl+C to quit.
Drive connected:    'Samsung Mighty Drive'

(gvfs-mount:4360): GVFS-RemoteVolumeMonitor-WARNING **: Owner :1.6223 of volume monitor org.gtk.Private.GduVolumeMonitor disconnected from the bus; removing drives/volumes/mounts
Drive disconnected: 'Samsung Mighty Drive'
Drive disconnected: 'Lecteur CD/DVD'
Comment 1 Pascal Terjan 2010-05-01 12:41:41 UTC
Also happens when plugging a memory card from a camera...
Comment 2 Pascal Terjan 2010-05-01 12:45:17 UTC
I get no warning and it does not crash, it just exits with code 1.
Comment 3 Pascal Terjan 2010-05-02 12:57:36 UTC
OK, I got it

On my system it adds drive_/dev/sdd_enclosed_by_Disques p\xe9riph\xe9riques__enclosed_by___machine_root_0__ and then exits.

If I start gvfs-gdu-volume-monitor with LC_ALL=C I get drive_/dev/sdd_enclosed_by_Peripheral Devices__enclosed_by___machine_root_0__ and it works fine.
Comment 4 Bastien Nocera 2010-05-02 18:45:44 UTC
Is udisks still running when that happens? the volume monitor is getting disconnected from the bus because it tries to pass, or receives invalid strings (eg. non-UTF8 strings).

There's probably a few iconv calls missing in the code.
Comment 5 Pascal Terjan 2010-05-02 19:13:44 UTC
udisks is working fine

The strings are created in gdu 

_("Peripheral Devices") in ensure_hub_peripheral in gdu-pool for the one used here.

If GduPresentable are supposed to have UTF-8 strings, then encoding must be initialized somewhere, maybe in gdu_pool_class_init
Comment 6 Pascal Terjan 2010-05-03 12:07:19 UTC
Created attachment 160188 [details] [review]
Possible fix

Here is a possible patch, assuming that GduPresentable ids are supposed to be UTF-8
Comment 7 Angelo Di Stasi 2010-06-09 18:20:40 UTC
(In reply to comment #6)
> Created an attachment (id=160188) [details] [review]
> Possible fix
> 
> Here is a possible patch, assuming that GduPresentable ids are supposed to be
> UTF-8

Attached patch fix the problem for me.
Here is the full bug tracker discussion thread: http://bugs.archlinux.org/task/19638
Comment 8 Pascal Terjan 2010-08-05 17:39:27 UTC
Ping
Comment 9 Ionut Biru 2010-10-07 13:34:15 UTC
what can i say, good jobs developers for not fixing this critical issue in this cycle. i hope it would be fixed in the next 2 or 3 cycles.
Comment 10 Pacho Ramos 2011-01-16 17:12:52 UTC
Still valid with 2.32, some Gentoo users got it recently, please take a look on this. Thanks
Comment 11 Pacho Ramos 2011-02-21 17:18:44 UTC
As reported in http://bugs.gentoo.org/show_bug.cgi?id=346955 , looks like gvfs also fails when user is using an invalid locale (like "it_CH.utf8" instead of "it_CH.UTF-8"). Gvfs shouldn't fail in this way in this cases
Comment 12 David Zeuthen (not reading bugmail) 2012-11-12 21:43:31 UTC
As of gnome-disk-utility 3.4 everything was rewritten to use udisks2 and GDBus.

Thanks for taking the time to report this bug.
However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use.

By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME.
Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.