After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616180 - Theme symbolic icons with text and named colours
Theme symbolic icons with text and named colours
Status: RESOLVED DUPLICATE of bug 614711
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 583766 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-04-19 13:52 UTC by Bastien Nocera
Modified: 2010-04-24 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Matthias' patch (7.30 KB, patch)
2010-04-19 13:54 UTC, Bastien Nocera 		needs-work Details | Review
Matthias' test program (770 bytes, text/plain)
2010-04-19 13:54 UTC, Bastien Nocera 		  Details

Description Bastien Nocera 2010-04-19 13:52:13 UTC 
When using symbolic icons names, GTK+ should "theme" the icons with a stylesheet, so that the icons follow the text colours, avoiding "gray on gray" or "white on white" type of problems with the display.

Furthermore, the stylesheet should contain information about the symbolic colours defined in the GTK+ theme, so that a low battery information could use the colour defined for "warning".
Comment 1 Bastien Nocera 2010-04-19 13:54:36 UTC 
Created attachment 159073 [details] [review]
Matthias' patch

We'd need to pass a full GtkStyle and state instead, so that GtkImage and GtkCellRendererPixbuf can modify the colours depending on state, and so that symbolic colours can be passed.
Comment 2 Bastien Nocera 2010-04-19 13:54:59 UTC 
Created attachment 159074 [details]
Matthias' test program
Comment 3 Christian Dywan 2010-04-20 10:49:00 UTC 
We have bug 614711 with the same patches already and some comments.
Comment 4 Bastien Nocera 2010-04-20 10:57:14 UTC 
My fault.

*** This bug has been marked as a duplicate of bug 614711 ***
Comment 5 Hylke Bons 2010-04-22 14:42:30 UTC 
*** Bug 583766 has been marked as a duplicate of this bug. ***