GNOME Bugzilla – Bug 616160
gedit-2.28.4 fails XML validation
Last modified: 2010-05-02 16:01:45 UTC
Created attachment 159060 [details] [review] Patch to fix XML markup Running make check shows XML validation errors for several languages: ============================ 8< =========================== xmllint --noout --noent --path de:./de --xinclude --postvalid ./de/gedit.xml ./de/gedit.xml:446: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (CDATA guimenu guimenuitem) Document ./de/gedit.xml does not validate xmllint --noout --noent --path el:./el --xinclude --postvalid ./el/gedit.xml xmllint --noout --noent --path es:./es --xinclude --postvalid ./es/gedit.xml xmllint --noout --noent --path fi:./fi --xinclude --postvalid ./fi/gedit.xml ./fi/gedit.xml:453: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (guimenu guimenuitem CDATA) ./fi/gedit.xml:1565: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (guimenu CDATA) Document ./fi/gedit.xml does not validate xmllint --noout --noent --path fr:./fr --xinclude --postvalid ./fr/gedit.xml xmllint --noout --noent --path hu:./hu --xinclude --postvalid ./hu/gedit.xml ./hu/gedit.xml:1742: element keycombo: validity error : Element keycombo content does not follow the DTD, expecting (keycap | keycombo | keysym | mousebutton)+, got (CDATA keycap keycap) Document ./hu/gedit.xml does not validate xmllint --noout --noent --path it:./it --xinclude --postvalid ./it/gedit.xml xmllint --noout --noent --path ja:./ja --xinclude --postvalid ./ja/gedit.xml xmllint --noout --noent --path ko:./ko --xinclude --postvalid ./ko/gedit.xml ./ko/gedit.xml:449: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (guimenu guimenuitem menuchoice) ./ko/gedit.xml:449: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (CDATA) ./ko/gedit.xml:1467: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (guimenu guimenuitem menuchoice) ./ko/gedit.xml:1467: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (CDATA) ./ko/gedit.xml:1845: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (guimenu guimenuitem CDATA menuchoice) ./ko/gedit.xml:1845: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (guimenu guimenuitem CDATA guimenuitem CDATA application CDATA) ./ko/gedit.xml:1897: element keycombo: validity error : Element keycombo content does not follow the DTD, expecting (keycap | keycombo | keysym | mousebutton)+, got (keycap keycap CDATA) Document ./ko/gedit.xml does not validate ============================ >8 =========================== Attached patch fixes affected *.po files. If you need additional information, please let me know. BR, Dustin
Can you provide us a git format patch? So we can review it easily and give you credit for it.
(In reply to comment #1) > Can you provide us a git format patch? So we can review it easily and give you > credit for it. Which repo should I checkout to create the format patch against?
To clone gedit: git clone git://git.gnome.org/gedit
Created attachment 159082 [details] [review] git format-patch to fix XML markup for de, fi, and hu translation Korean translation seems to be fixed in master branch, so git format-patch only for German, Finnish, and Hungarian translations.
Hey, im far from sure if im right here, redirect if so: I have the mainboard Asus P4P800-VM-SI in which my Linux (installed 3 months ago) does not recognize the microphone function. Regards, teo
Review of attachment 159082 [details] [review]: ::: help/de/de.po @@ +1047,3 @@ msgstr "" "Um die Syntax-Hervorhebung aus dem Text zu entfernen, wählen Sie " +"<menuchoice><guimenu>Suchen</guimenu><guimenuitem>Hervorhebung " Disclaimer: I do not speak a word of german, but here beside fixing the xml, you also removed "Bearbeiten". Was this intentional?
(In reply to comment #6) > Review of attachment 159082 [details] [review]: > > ::: help/de/de.po > @@ +1047,3 @@ > msgstr "" > "Um die Syntax-Hervorhebung aus dem Text zu entfernen, wählen Sie " > +"<menuchoice><guimenu>Suchen</guimenu><guimenuitem>Hervorhebung " > > Disclaimer: I do not speak a word of german, but here beside fixing the xml, > you also removed "Bearbeiten". Was this intentional? Yes, this is intentional. I am a German native speaker and installed gedit with German translation to check how the correct entry in the menu shows up. "Bearbeiten" is definitely the wrong <guimenu>. You can check yourself with German translations installed to make sure. BR, Dustin
Okay, I pushed your patch to git. Thanks!