After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616061 - gtk_menu_attach_to_widget() free detach func immediately after called
gtk_menu_attach_to_widget() free detach func immediately after called
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-04-17 21:48 UTC by Kevin Ryde
Modified: 2010-04-24 22:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtk2perl_menu_detach_func() free the detach func after called (2.85 KB, patch)
2010-04-17 21:48 UTC, Kevin Ryde
committed Details | Review

Description Kevin Ryde 2010-04-17 21:48:40 UTC
Created attachment 158990 [details] [review]
gtk2perl_menu_detach_func() free the detach func after called

I believe the detach func in gtk_menu_attach_to_widget() is only called once and that whatever closure etc is there can be freed immediately after the detach.

The benefit would be to immediately release anything captured by a closure in that detach func, as opposed to waiting until the next attach_to_widget(), which of course might be either a long time or perhaps never.
Comment 1 Torsten Schoenfeld 2010-04-24 22:52:18 UTC
Looks good to me.  Committed.  Thanks for the patch, and thanks for preparing
it in git format.