After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616039 - New tests for nullable arguments
New tests for nullable arguments
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-04-17 17:40 UTC by Zach Goldberg
Modified: 2015-02-07 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a bunch of new tests for nullable args in Everything module (6.04 KB, patch)
2010-04-17 17:40 UTC, Zach Goldberg 		reviewed Details | Review
Add a bunch of new tests for nullable args in Everything module (6.08 KB, patch)
2010-04-17 19:09 UTC, Zach Goldberg 		none Details | Review
Add a bunch of new tests for nullable args in Everything module (6.09 KB, patch)
2010-04-17 19:13 UTC, Zach Goldberg 		none Details | Review
Add a bunch of new tests for nullable args in Everything module (10.31 KB, patch)
2010-04-17 20:26 UTC, Zach Goldberg 		none Details | Review
Add a bunch of new tests for nullable args in Everything module (10.33 KB, patch)
2010-04-17 20:30 UTC, Zach Goldberg 		none Details | Review
Add a bunch of new tests for nullable args in Everything module (10.33 KB, patch)
2010-04-17 20:45 UTC, Zach Goldberg 		accepted-commit_now Details | Review

Description Zach Goldberg 2010-04-17 17:40:43 UTC 
This adds some extra functions to everything to test with language bindings (pygi) to excercise nullable argument support for various pointer types.
Comment 1 Zach Goldberg 2010-04-17 17:40:44 UTC 
Created attachment 158964 [details] [review]
Add a bunch of new tests for nullable args in Everything module
Comment 2 Colin Walters 2010-04-17 19:04:35 UTC 
Review of attachment 158964 [details] [review]:

::: gir/everything.c
@@ +747,3 @@
+ * @in: (allow-none):
+ * test_array_int_null_in:
+/**

Arrays without length are bad form; you can get away with this for char * but not for int * I think.

So this should be:
@in: (array length=1) (allow-none)
@len: length
void test_array_int_null_in (int *in, int len)
{
}
Comment 3 Zach Goldberg 2010-04-17 19:09:21 UTC 
Created attachment 158967 [details] [review]
Add a bunch of new tests for nullable args in Everything module
Comment 4 Zach Goldberg 2010-04-17 19:13:29 UTC 
Created attachment 158968 [details] [review]
Add a bunch of new tests for nullable args in Everything module
Comment 5 Zach Goldberg 2010-04-17 20:26:10 UTC 
Created attachment 158971 [details] [review]
Add a bunch of new tests for nullable args in Everything module
Comment 6 Zach Goldberg 2010-04-17 20:30:06 UTC 
Created attachment 158972 [details] [review]
Add a bunch of new tests for nullable args in Everything module
Comment 7 Zach Goldberg 2010-04-17 20:45:00 UTC 
Created attachment 158973 [details] [review]
Add a bunch of new tests for nullable args in Everything module
Comment 8 Colin Walters 2010-04-17 21:26:21 UTC 
Review of attachment 158973 [details] [review]:

Looks good to me
Comment 9 Zach Goldberg 2010-04-17 21:30:51 UTC 
Pushed in 7b6656e2f39d88671758dbf0775688fc53660936
Comment 10 André Klapper 2015-02-07 17:03:42 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]