After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616035 - Nullable argument support
Nullable argument support
Status: RESOLVED FIXED
Product: pygi
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: 0.6
Assigned To: pygi-maint
pygi-maint
: 607664 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-04-17 15:26 UTC by Zach Goldberg
Modified: 2010-04-18 15:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Work on nullable args for Dictionaries/GHashTables (4.65 KB, patch)
2010-04-17 16:53 UTC, Zach Goldberg 		none Details | Review
Implement nullable argument support, including tests (8.28 KB, patch)
2010-04-17 19:39 UTC, Zach Goldberg 		none Details | Review
Implement nullable argument support, including tests (8.80 KB, patch)
2010-04-17 20:46 UTC, Zach Goldberg 		accepted-commit_now Details | Review

Description Zach Goldberg 2010-04-17 15:26:36 UTC 
PyGI needs to allow you to pass None to a parameter that has the (allow-none) annotation.
Comment 1 Zach Goldberg 2010-04-17 16:53:44 UTC 
Created attachment 158958 [details] [review]
Work on nullable args for Dictionaries/GHashTables
Comment 2 Zach Goldberg 2010-04-17 19:39:23 UTC 
Created attachment 158970 [details] [review]
Implement nullable argument support, including tests
Comment 3 Zach Goldberg 2010-04-17 20:46:23 UTC 
Created attachment 158974 [details] [review]
Implement nullable argument support, including tests

This patch includes both in and out argument tests.
Comment 4 Zach Goldberg 2010-04-17 21:01:20 UTC 
Note: this bug is a duplicate of 607664 but I don't have permission to touch that bug.  So when this patch goes in I'll mark this one resolved and simon can resolve 607664.
Comment 5 Tomeu Vizoso 2010-04-18 14:46:35 UTC 
*** Bug 607664 has been marked as a duplicate of this bug. ***
Comment 6 Tomeu Vizoso 2010-04-18 15:03:46 UTC 
Review of attachment 158974 [details] [review]:

Looks great!
Comment 7 Zach Goldberg 2010-04-18 15:30:25 UTC 
Pushed in 79aa416ae8632b123da61d79fb820d9e2704209c