After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615995 - CPU Load goes to 100% when viewing saved credentials (not ssh keys)
CPU Load goes to 100% when viewing saved credentials (not ssh keys)
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
2.30.x
Other Linux
: Normal normal
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2010-04-16 21:17 UTC by Angel Abad
Modified: 2011-03-10 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make the set_acl function (1.83 KB, patch)
2010-07-02 03:26 UTC, Holger Hans Peter Freyther 		none Details | Review
Fix high CPU usage due querying and setting the acl as fast as possible (1.64 KB, patch)
2010-07-02 03:27 UTC, Holger Hans Peter Freyther 		none Details | Review

Description Angel Abad 2010-04-16 21:17:02 UTC 
In Ubuntu Lucid Maxim Webster reported:

I have various login credentials (web bases logins) stored for seahorse. Those logins are displayes using a tabbed list view in seahorse. When double-clicking an entry, to view details (including masked / unmasked) password, the CPU Load goes to 100% upon the dialog being opened. It falls down to expected level upon closing the dialog again.

Launchpad ref: https://bugs.edge.launchpad.net/ubuntu/+source/seahorse/+bug/556349

Thanks!
Comment 1 Holger Hans Peter Freyther 2010-07-02 03:26:27 UTC 
Created attachment 165068 [details] [review]
Make the set_acl function

Make the function static as it is not used outside of the item itself.
Comment 2 Holger Hans Peter Freyther 2010-07-02 03:27:36 UTC 
Created attachment 165069 [details] [review]
Fix high CPU usage due querying and setting the acl as fast as possible

This patch contains the analysis and the proposed fix, it is against the latest seahorse...
Comment 3 Adam Schreiber 2010-07-19 20:18:39 UTC 
Holger,

Your patch looks good, what happens if someone else modifies the ACL list externally to seahorse and then the acl is queried again?  Will the changes show up?
Comment 4 Holger Hans Peter Freyther 2010-07-23 14:21:42 UTC 
Any idea how one can test this? The other option for the patch is to not send the notify when setting an empty list when the current one is empty too. With this the call to get_acl would not happen and we would not query for it.
Comment 5 Pavol Klačanský 2010-09-15 13:31:38 UTC 
steps to reproduce:
1. open keyring (login)
2. select and open one entry in this keyring
3. see 100% cpu usage in top
Comment 6 Thibault Lemaitre 2011-02-21 10:33:03 UTC 
I have a similar bug. I'm using Ubuntu 10.10 and seahorse 2.32.0. from the repositories.

In fact my CPU goes to 100% only when I open the properties windows in the "Password" tab, not in the two other tabs.
Comment 7 Stef Walter 2011-03-10 08:32:51 UTC 
This should fix the issue. Thanks for the report.


commit 66d407eae68ab57e62fa3581fee891ed251adc9d
Author: Stef Walter <stefw@collabora.co.uk>
Date:   Fri Feb 4 02:57:57 2011 +0100

    Fix infinite loop when a keyring item is open.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=641018