After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615941 - [tags] Add GST_TAG_DEVICE_MANUFACTURER and GST_TAG_DEVICE_MODEL
[tags] Add GST_TAG_DEVICE_MANUFACTURER and GST_TAG_DEVICE_MODEL
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal enhancement
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-16 09:59 UTC by Thiago Sousa Santos
Modified: 2010-05-03 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tags: Adds GST_TAG_DEVICE_MAKE and GST_TAG_DEVICE_MODEL (2.34 KB, patch)
2010-04-16 10:00 UTC, Thiago Sousa Santos 		none Details | Review
tags: Adds GST_TAG_DEVICE_MANUFACTURER and GST_TAG_DEVICE_MODEL (2.36 KB, patch)
2010-04-23 02:10 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2010-04-16 09:59:32 UTC 
We don't have tags to add/read to/from medias the manufacturer and model of the device used to create a media file.

I propose adding those.
Comment 1 Thiago Sousa Santos 2010-04-16 10:00:04 UTC 
Created attachment 158878 [details] [review]
tags: Adds GST_TAG_DEVICE_MAKE and GST_TAG_DEVICE_MODEL

Adds those new tags to describe the device manufacturer and
model used to create medias.

API: GST_TAG_DEVICE_MAKE
API: GST_TAG_DEVICE_MODEL

Fixes #615941
Comment 2 Sebastian Dröge (slomo) 2010-04-16 11:38:22 UTC 
Why don't you use MANUFACTURER instead of MAKE? Other than this it looks good to me
Comment 3 Edward Hervey 2010-04-16 11:56:33 UTC 
MANUFACTURER or even BRAND would be better than MAKE.
Comment 4 Thiago Sousa Santos 2010-04-16 12:07:07 UTC 
I picked MAKE because that is how tiff calls it (and consequently how exif/xmp, too).

<bikeshed> Between MANUFACTURER and BRAND I prefer BRAND. </bikeshed>
Comment 5 Thiago Sousa Santos 2010-04-23 02:10:46 UTC 
Created attachment 159383 [details] [review]
tags: Adds GST_TAG_DEVICE_MANUFACTURER and GST_TAG_DEVICE_MODEL

Updated to use _MANUFACTURER instead of _MAKE
Comment 6 Tim-Philipp Müller 2010-04-30 07:43:06 UTC 
Comment on attachment 159383 [details] [review]
tags: Adds GST_TAG_DEVICE_MANUFACTURER and GST_TAG_DEVICE_MODEL

"MAKE" sounds more correct to me, since that's what it says on the product, while the "manufacturer" is often some other company no one has ever heard of. But if the majority consensus is manufacturer, so be it ;-)
Comment 7 Benjamin Otte (Company) 2010-04-30 08:35:47 UTC 
Well, _MAKE is a verb, and we use subjects for tag names. I suppose that's the biggest reason why people don't like it.
Comment 8 Tim-Philipp Müller 2010-04-30 09:00:33 UTC 
> Well, _MAKE is a verb, and we use subjects for tag names. I suppose that's the
> biggest reason why people don't like it.

It is also a noun.
Comment 9 Thiago Sousa Santos 2010-05-03 17:00:55 UTC 
Fixed.

Module: gstreamer
Branch: master
Commit: 2cc0bcb798442e50856bfb9e51477a88d8a7723b
URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=2cc0bcb798442e50856bfb9e51477a88d8a7723b

Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Fri Apr 16 06:57:05 2010 -0300

tags: Adds GST_TAG_DEVICE_MANUFACTURER and GST_TAG_DEVICE_MODEL

Adds those new tags to describe the device manufacturer and
model used to create medias.

API: GST_TAG_DEVICE_MANUFACTURER
API: GST_TAG_DEVICE_MODEL

Fixes #615941