After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615773 - Add test_cairo_create to Everything
Add test_cairo_create to Everything
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-04-14 19:01 UTC by Tomeu Vizoso
Modified: 2015-02-07 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add test_cairo_create to Everything (2.39 KB, patch)
2010-04-14 19:01 UTC, Tomeu Vizoso 		reviewed Details | Review
Add foreign struct funcs to Everything (4.39 KB, patch)
2010-04-15 21:25 UTC, Tomeu Vizoso 		none Details | Review
Add foreign struct funcs to Everything (7.27 KB, patch)
2010-04-15 21:47 UTC, Tomeu Vizoso 		accepted-commit_now Details | Review

Description Tomeu Vizoso 2010-04-14 19:01:57 UTC 
So bindings can test their integration with non-gobject libs
Comment 1 Tomeu Vizoso 2010-04-14 19:01:59 UTC 
Created attachment 158745 [details] [review]
Add test_cairo_create to Everything
Comment 2 Johan (not receiving bugmail) Dahlin 2010-04-14 19:04:32 UTC 
Review of attachment 158745 [details] [review]:

Needs a bit of work.

::: gir/Makefile.am
@@ +172,3 @@
 Everything_1_0_gir_PACKAGES = gobject-2.0
 Everything_1_0_gir_LIBS = libgirepository-everything-1.0.la
+Everything_1_0_gir_INCLUDES = GObject-2.0 PangoCairo-1.0

PangoCairo-1.0 doesn't seem right.

::: gir/everything.c
@@ +209,1 @@
   return &value;

This misses two tests;
1) returning a newly created image surface
2) returning a pointer to an internal image surface, with annotations (transfer full)
Comment 3 Johan (not receiving bugmail) Dahlin 2010-04-14 19:04:33 UTC 
Review of attachment 158745 [details] [review]:

Needs a bit of work.

::: gir/Makefile.am
@@ +172,3 @@
 Everything_1_0_gir_PACKAGES = gobject-2.0
 Everything_1_0_gir_LIBS = libgirepository-everything-1.0.la
+Everything_1_0_gir_INCLUDES = GObject-2.0 PangoCairo-1.0

PangoCairo-1.0 doesn't seem right.

::: gir/everything.c
@@ +209,1 @@
   return &value;

This misses two tests;
1) returning a newly created image surface
2) returning a pointer to an internal image surface, with annotations (transfer full)
Comment 4 Johan (not receiving bugmail) Dahlin 2010-04-14 19:04:34 UTC 
Review of attachment 158745 [details] [review]:

Needs a bit of work.

::: gir/Makefile.am
@@ +172,3 @@
 Everything_1_0_gir_PACKAGES = gobject-2.0
 Everything_1_0_gir_LIBS = libgirepository-everything-1.0.la
+Everything_1_0_gir_INCLUDES = GObject-2.0 PangoCairo-1.0

PangoCairo-1.0 doesn't seem right.

::: gir/everything.c
@@ +209,1 @@
   return &value;

This misses two tests;
1) returning a newly created image surface
2) returning a pointer to an internal image surface, with annotations (transfer full)
Comment 5 Tomeu Vizoso 2010-04-15 21:25:21 UTC 
Created attachment 158841 [details] [review]
Add foreign struct funcs to Everything
Comment 6 Tomeu Vizoso 2010-04-15 21:47:00 UTC 
Created attachment 158845 [details] [review]
Add foreign struct funcs to Everything
Comment 7 Colin Walters 2010-04-16 14:56:48 UTC 
Review of attachment 158845 [details] [review]:

Looks fine.  Note for the Fedora package I moved the Everything.{gir,typelib} to the -devel package which makes me more OK with the change to dep on cairo.
Comment 8 André Klapper 2015-02-07 16:50:30 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]