After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615756 - [bin] refcount issue when removing element in error
[bin] refcount issue when removing element in error
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-14 16:20 UTC by Wim Taymans
Modified: 2010-04-14 16:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.74 KB, patch)
2010-04-14 16:23 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2010-04-14 16:20:18 UTC 
When an element is removed from a bin while it has a state change error, we unref the element once too much.
Comment 1 Wim Taymans 2010-04-14 16:23:08 UTC 
Created attachment 158729 [details] [review]
proposed patch

this patch removes the superfluous unref and adds a unit test.
Comment 2 Wim Taymans 2010-04-14 16:33:44 UTC 
commit 67ab660b193dcaa41af9e147f62c4144ddae499f
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Wed Apr 14 17:56:17 2010 +0200

    bin: fix refcount when removing elements during state change
    
    When an element is removed from a bin because it caused a state change error,
    don't unref the child twice.
    Add some more debug info.
    Add a unit test for this error.
    
    Fixes #615756