GNOME Bugzilla – Bug 615711
When deleting SoupCookieJarSqlite cookies, cookie content is still stored on disk
Last modified: 2010-04-26 20:18:03 UTC
In default SQLite compilations, for performance reasons SQLite is not deleting database content when delete is requested, but is just marking some part of table content as deleted. In case of SoupCookieJarSqlite cookies stored in SQLite database such behavior can be major security issue. Even if libsoup user decides to delete cookies, their content still stays on disk in readable form. Fortunately in 3.6.23 version of SQLite new PRAGMA statement was introduced allowing to change default behavior of database. When PRAGMA secure_delete set on, SQLite overwrites deleted content with zeros. Attached patch turns secure_delete on in SoupCookieJarSqlite cookie database. see also http://www.sqlite.org/changes.html#version_3_6_23 http://www.sqlite.org/pragma.html#pragma_secure_delete
Created attachment 158678 [details] [review] turning on PRAGMA secure_delete in SoupCookieJarSqlite,
kov/xan, any thoughts on this? "There is a small performance penalty for this since additional I/O must occur." but I think overwriting old cookies with new values is more common than deleting cookies anyway
(In reply to comment #2) > kov/xan, any thoughts on this? "There is a small performance penalty for this > since additional I/O must occur." but I think overwriting old cookies with new > values is more common than deleting cookies anyway I don't think deleting cookies is very common, as you say, so I don't care too much either way.
+1 from me, if this shows up in profiling runs we can revisit, but I doubt it will =)
committed, and will go into 2.30.1