After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615565 - [PATCH] Check box needs to be indented
[PATCH] Check box needs to be indented
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Keyboard
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-12 19:07 UTC by Allan Day
Modified: 2011-06-20 14:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Mockup of the layouts tab (86.29 KB, image/png)
2010-04-12 19:07 UTC, Allan Day 		  Details
Proposed bugfix (118.07 KB, application/x-designer)
2010-10-19 22:02 UTC, Fabrizio Mele 		  Details
Proposed patch (12.97 KB, patch)
2010-10-19 22:59 UTC, Fabrizio Mele 		none Details | Review

Description Allan Day 2010-04-12 19:07:02 UTC 
Created attachment 158520 [details]
Mockup of the layouts tab

In the Layouts tab of the Keyboard Preferences dialog, there is a check box with the label 'New windows use active window's layout'. This check box needs to be indented 12 pixels to the right, since it is dependent upon and secondary to the check box which is above it.

I'm afraid this bug is my fault. I got the spacing wrong on my initial design.

I have attached a mockup detailing the necessary spacing.

This bug is a part of the keyboard preferences design review. More information can be found here: http://live.gnome.org/UsabilityProject/Whiteboard/KeyboardPreferences
Comment 1 Fabrizio Mele 2010-10-19 21:54:32 UTC 
I started working for fixing this bug
Comment 2 Fabrizio Mele 2010-10-19 22:02:31 UTC 
Created attachment 172771 [details]
Proposed bugfix 

This should be the corrected versione of ~/capplets/keyboard/gnome-keyboard-properties-dialog.ui
Comment 3 Fabrizio Mele 2010-10-19 22:59:38 UTC 
Created attachment 172779 [details] [review]
Proposed patch
Comment 4 Sergey V. Udaltsov 2010-11-12 23:53:58 UTC 
Fabrizio, could you please update your patch to the current state of git? I cannot apply it :(
Comment 5 Tobias Mueller 2011-02-24 18:22:50 UTC 
Fabrizio, Ping.
Comment 6 Fabio Durán Verdugo 2011-06-12 16:27:50 UTC 
Fabrizio, Ping!
Comment 7 Fabrizio Mele 2011-06-12 16:40:20 UTC 
i have tried many times to apply that patch but it failed. i'm trying again now.
Comment 8 Bastien Nocera 2011-06-20 14:40:46 UTC 
This patch is outdated, and unapplicable.

Also note that replacing "C" locale formatted numbers by comma separated ones is broken.