GNOME Bugzilla – Bug 615435
Does not compile with -DGSEAL_ENABLE
Last modified: 2010-05-10 09:17:28 UTC
This module does not build with -DGSEAL_ENABLE. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. goocanvasatk.c: In function ‘goo_canvas_item_accessible_get_item_extents’: goocanvasatk.c:62: error: ‘GtkAdjustment’ has no member named ‘value’ goocanvasatk.c:63: error: ‘GtkAdjustment’ has no member named ‘value’ goocanvasatk.c:64: error: ‘GtkAdjustment’ has no member named ‘value’ goocanvasatk.c:65: error: ‘GtkAdjustment’ has no member named ‘value’ goocanvasatk.c: In function ‘goo_canvas_item_accessible_is_item_in_window’: goocanvasatk.c:88: error: ‘GtkWidget’ has no member named ‘allocation’ goocanvasatk.c:89: error: ‘GtkWidget’ has no member named ‘allocation’ goocanvasatk.c: In function ‘goo_canvas_item_accessible_get_extents’: goocanvasatk.c:134: error: ‘GtkWidget’ has no member named ‘window’ goocanvasatk.c:144: error: ‘GtkWidget’ has no member named ‘window’ goocanvasatk.c:151: error: ‘GtkWidget’ has no member named ‘window’ goocanvasatk.c: In function ‘goo_canvas_item_accessible_grab_focus’: goocanvasatk.c:225: error: ‘GtkObject’ has no member named ‘flags’ goocanvasatk.c: In function ‘goo_canvas_item_accessible_ref_state_set’: goocanvasatk.c:417: error: ‘GtkObject’ has no member named ‘flags’ goocanvasatk.c:421: error: ‘GtkObject’ has no member named ‘flags’ goocanvasatk.c: In function ‘goo_canvas_accessible_get_n_children’: goocanvasatk.c:642: error: ‘GtkAccessible’ has no member named ‘widget’ goocanvasatk.c: In function ‘goo_canvas_accessible_ref_child’: goocanvasatk.c:670: error: ‘GtkAccessible’ has no member named ‘widget’ make[3]: *** [goocanvasatk.lo] Error 1 make[3]: Leaving directory `/home/andre/svn-gnome/goocanvas/src'
Created attachment 159273 [details] [review] Compile with -GSEAL Patch added to remove deprecated stuff and make it GTK3 ready
I commited to git master http://git.gnome.org/browse/goocanvas/commit/?id=866d3e7a0c8b6a65377633b6fac758be3eed099c This way goocanvas will compile with gtk+-3.0 Thanks
Review of attachment 159273 [details] [review]: pushed to master
Thanks for creating the patch. Though I don't really see why GTK+ removed the macros like GTK_WIDGET_REALIZED(), GTK_WIDGET_VISIBLE() and GTK_WIDGET_DRAWABLE(). Seems pointless really. By the way there was a small error in the patch. See bug #617256.
Sorry for the typo :/ About the -GSeal stuff read http://live.gnome.org/GnomeGoals/UseGseal Those old symbols will be removed from GTK+-3.0.
You seem to have committed this, but you forgot to add an entry to the ChangeLog.
People don't seem to be using ChangeLogs as much now. See http://live.gnome.org/Git/ChangeLog I didn't add an entry either because of that. I'm not sure what to do really.
If you don't want to use the ChangeLog then please add some hint to the file, like other projects do. goocanvas should do one or the other. Personally, I hate the lack of ChangeLogs, and resulting decrease in quality and communication, that I see in other projects, so I won't encourage you.
Yes, I like ChangeLogs, at least for small projects. So I think I'll keep it.