After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615407 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Product: vinagre
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Jonh Wendell
Depends on: 620832
Blocks: 585391
Reported: 2010-04-10 22:38 UTC by André Klapper
Modified: 2010-06-25 22:49 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30

First patch to make vinagre use SEAL (25.99 KB, patch)
2010-04-15 21:09 UTC, Marcus Carlson
rejected Details | Review

Description André Klapper 2010-04-10 22:38:34 UTC
This module does not build with -DGSEAL_ENABLE.
See .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

make[4]: Entering directory `/home/andre/svn-gnome/vinagre/vinagre/view'
  CC     autoDrawer.lo
autoDrawer.c: In function »ViewAutoDrawerEnforce«:
autoDrawer.c:96: Error: »GtkWidget« has no element named »allocation«
autoDrawer.c: In function »ViewAutoDrawerUpdate«:
autoDrawer.c:186: Error: »GtkWidget« has no element named »allocation«
autoDrawer.c:187: Error: »GtkWidget« has no element named »allocation«
autoDrawer.c:214: Error: »GtkWindow« has no element named »group«
autoDrawer.c:214: Error: »GtkWindow« has no element named »group«
autoDrawer.c:215: Error: »GtkWindow« has no element named »group«
make[4]: *** [autoDrawer.lo] Error 1
make[4]: Leaving directory `/home/andre/svn-gnome/vinagre/vinagre/view'
make[3]: *** [all-recursive] Error 1
Comment 1 Marcus Carlson 2010-04-15 21:09:33 UTC
Created attachment 158838 [details] [review]
First patch to make vinagre use SEAL

WIP - just in case I won't have time to finish it. Hope it helps someone :)
At least it compiles and can connect to VNC without segfault, but it's quite a few hacks here and there...
Comment 2 André Klapper 2010-04-16 14:19:02 UTC
Hi Marcus, thanks for the patch!
It's missing a bump of GTK_REQUIRED (currently 2.13.1) in
Comment 3 Marcus Carlson 2010-04-16 17:31:33 UTC
André, it's missing a lot of things ;) but thanks for the heads up! Hopefully I got time to work at this during the weekend.
Comment 4 André Klapper 2010-06-01 12:45:33 UTC
Marcus: Any plans to continue working on this? Just asking so in case no somebody could continue and we don't duplicate work...
Comment 5 Marcus Carlson 2010-06-01 16:44:11 UTC
Hmm. I do have a slightly better patch but it doesn't run correct anyway so if you'd like to continue the work - feel free - I probably won't have time for it in a while...
Comment 6 Jonh Wendell 2010-06-07 13:16:52 UTC
I'm working on it. Since vinagre uses a copy of libview, the right thing to do is to fix libview itself. I'm doing this but stopped in a gtk+ issue: Bug #620832
Comment 7 Jonh Wendell 2010-06-07 13:34:55 UTC
Comment on attachment 158838 [details] [review]
First patch to make vinagre use SEAL

I'll work on that
Comment 8 André Klapper 2010-06-22 09:16:17 UTC
Can we at least get everything fixed soon (2.31.4) except for bug 620832 so once 620832 is fixed that it's only a trivial change? :-/
Comment 9 Jonh Wendell 2010-06-25 22:49:39 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.