Bug 615395 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: others
0.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-mag-maint
gnome-mag-maint
:
Depends on:
Blocks: 585391
  Show dependency tree
 
Reported: 2010-04-10 20:42 UTC by André Klapper
Modified: 2010-04-25 23:01 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
Make gnome-mag compile with -DGSEAL_ENABLE (21.56 KB, patch)
2010-04-10 21:25 UTC, André Klapper
none Details | Diff | Review
Enables GSEAL compilation and bumps GTK+ required version to 2.14 (23.32 KB, patch)
2010-04-10 21:52 UTC, Stéphane Maniaci
none Details | Diff | Review

Description André Klapper 2010-04-10 20:42:41 UTC
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

magnifier.c: In function ‘mag_login_helper_get_raise_windows’:
magnifier.c:147: error: ‘GtkWidget’ has no member named ‘window’
magnifier.c: In function ‘magnifier_set_cursor_from_pixbuf’:
magnifier.c:285: error: ‘GtkWidget’ has no member named ‘window’
magnifier.c:312: warning: passing argument 1 of ‘g_object_get_data’ from incompatible pointer type
/home/andre/opt-gnome/include/glib-2.0/gobject/gobject.h:488: note: expected ‘struct GObject *’ but argument is of type ‘struct GdkPixbuf *’
magnifier.c:313: warning: passing argument 1 of ‘g_object_get_data’ from incompatible pointer type
/home/andre/opt-gnome/include/glib-2.0/gobject/gobject.h:488: note: expected ‘struct GObject *’ but argument is of type ‘struct GdkPixbuf *’
magnifier.c: In function ‘magnifier_transform_cursor’:
magnifier.c:793: error: ‘GtkWidget’ has no member named ‘window’
magnifier.c:802: error: ‘GtkWidget’ has no member named ‘window’
magnifier.c: In function ‘magnifier_class_init’:
magnifier.c:2043: warning: assignment from incompatible pointer type
make[3]: *** [magnifier-magnifier.o] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/gnome-mag/magnifier'
make[2]: *** [all] Error 2
Comment 1 André Klapper 2010-04-10 21:25:42 UTC
Created attachment 158389 [details] [review]
Make gnome-mag compile with -DGSEAL_ENABLE

Trivial patch, but bumps gtk+ requirement from 2.12 to 2.14.
Comment 2 Stéphane Maniaci 2010-04-10 21:52:51 UTC
Created attachment 158390 [details] [review]
Enables GSEAL compilation and bumps GTK+ required version to 2.14

This patch does the job although I'm not sure at all of the configure.in modifications. Please review.
Comment 3 Stéphane Maniaci 2010-04-10 23:05:00 UTC
Dang it ! :-D
Comment 4 André Klapper 2010-04-23 16:16:31 UTC
Comment on attachment 158389 [details] [review]
Make gnome-mag compile with -DGSEAL_ENABLE

Stephane's patch is better. Hence marking mine as obsolete.
Comment 5 Carlos Eduardo Rodrigues Diógenes 2010-04-25 23:01:26 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Note You need to log in before you can comment on or make changes to this bug.