GNOME Bugzilla – Bug 615392
Does not compile with -DGSEAL_ENABLE
Last modified: 2010-05-11 13:20:22 UTC
This module does not build with -DGSEAL_ENABLE. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. gtksourceview.c: In function ‘notify_buffer’: gtksourceview.c:859: error: ‘GtkTextView’ has no member named ‘buffer’ gtksourceview.c: In function ‘move_cursor’: gtksourceview.c:1912: error: ‘GtkTextView’ has no member named ‘buffer’ gtksourceview.c: In function ‘gtk_source_view_move_cursor’: gtksourceview.c:1985: error: ‘GtkTextView’ has no member named ‘buffer’ gtksourceview.c: In function ‘gtk_source_view_paint_line_background’: gtksourceview.c:2169: error: ‘GtkTextView’ has no member named ‘hadjustment’ gtksourceview.c:2171: error: ‘GtkTextView’ has no member named ‘hadjustment’ gtksourceview.c: In function ‘gtk_source_view_expose’: gtksourceview.c:2773: error: ‘GtkObject’ has no member named ‘flags’ gtksourceview.c:2773: error: ‘GtkObject’ has no member named ‘flags’ gtksourceview.c:2780: error: ‘GtkTextView’ has no member named ‘buffer’ gtksourceview.c:2782: error: ‘GtkTextView’ has no member named ‘buffer’ gtksourceview.c:2788: error: ‘GtkWidget’ has no member named ‘style’ gtksourceview.c:2788: error: ‘GtkWidget’ has no member named ‘state’ gtksourceview.c: In function ‘set_mark_category_tooltip_func’: gtksourceview.c:3423: error: ‘GtkObject’ has no member named ‘flags’ gtksourceview.c: In function ‘gtk_source_view_key_press_event’: gtksourceview.c:4177: error: ‘GtkTextView’ has no member named ‘im_context’ gtksourceview.c: In function ‘view_dnd_drop’: gtksourceview.c:4384: error: ‘GtkSelectionData’ has no member named ‘length’ gtksourceview.c:4387: error: ‘GtkSelectionData’ has no member named ‘format’ gtksourceview.c:4387: error: ‘GtkSelectionData’ has no member named ‘length’ gtksourceview.c:4393: error: ‘GtkSelectionData’ has no member named ‘data’ gtksourceview.c: In function ‘update_right_margin_colors’: gtksourceview.c:4676: error: ‘GtkObject’ has no member named ‘flags’ gtksourceview.c:4731: error: ‘GtkWidget’ has no member named ‘style’ gtksourceview.c: In function ‘update_spaces_color’: gtksourceview.c:4739: error: ‘GtkObject’ has no member named ‘flags’ gtksourceview.c:4773: error: ‘GtkWidget’ has no member named ‘style’ gtksourceview.c: In function ‘gtk_source_view_update_style_scheme’: gtksourceview.c:4834: error: ‘GtkObject’ has no member named ‘flags’ make[4]: *** [gtksourceview.lo] Error 1 make[4]: Leaving directory `/home/andre/svn-gnome/gtksourceview/gtksourceview'
I'm working on this.
Created attachment 158966 [details] [review] Start fixing compilation with -DGSEAL_ENABLE These changes are in a patch of their own because I think they should be reviewed with extra care
Created attachment 160673 [details] [review] Use accessor functions instead direct access Except for the attachment above all direct access now uses functions. This also raises the GTK+ minimum version to 2.16.0.
Comment on attachment 160673 [details] [review] Use accessor functions instead direct access Thanks a lot for the patch. Reviewed and pushed.
Are we still missing any accessor here, or should we close this?
Created attachment 160811 [details] [review] Patch for the remaining stuff Seems like there is only one issue left.
Argh. Mirsal's patch probably makes more sense than mine. Sorry for the noise.
Was Mirsal's patch applied already? If it's applied I think we can close this?
> Was Mirsal's patch applied already? If it's applied I think we can close this? Nope :)
Comment on attachment 158966 [details] [review] Start fixing compilation with -DGSEAL_ENABLE Reviewed and pushed. Thanks for it.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.