GNOME Bugzilla – Bug 615348
Does not compile with -DGSEAL_ENABLE
Last modified: 2010-10-29 10:15:41 UTC
This module does not build with -DGSEAL_ENABLE. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.
Created attachment 167866 [details] [review] Build ToolbarEditor with GSEAL
+ pos = gtk_toolbar_get_item_index (GTK_TOOLBAR (gtk_widget_get_parent (widget)), GTK_TOOL_ITEM (widget)); - toolbar_pos = get_toolbar_position (etoolbar, widget->parent); + toolbar_pos = get_toolbar_position (etoolbar, gtk_widget_get_parent (widget)); Don't use the same getter repeatedly in the same function; if there's more than one call to it, create a temp variable to hold the result. Is this patch a straight port from the gseal fixes from evince's copy of toolbar-editor, or an independent effort?
> Don't use the same getter repeatedly in the same function; if there's more than > one call to it, create a temp variable to hold the result. True, fixed in this new patch. > Is this patch a straight port from the gseal fixes from evince's copy of > toolbar-editor, or an independent effort? Actually I was trying to build gtranslator with GSEAL enabled. Its copy of toolbareditor was blocking the build. So, instead of fix it there, I looked at "upstream" egg and as it's not fixed yet, I came up with this patch.
Created attachment 167868 [details] [review] Build ToolbarEditor with GSEAL #2nd try
Comment on attachment 167868 [details] [review] Build ToolbarEditor with GSEAL #2nd try pushed to master, thanks.
Closing then.