After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615258 - Keyboard capplet General tab revamp
Keyboard capplet General tab revamp
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Keyboard
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 605498 605501 615206
Blocks:
 
 
Reported: 2010-04-09 08:45 UTC by Allan Day
Modified: 2011-01-27 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
General tab from git (28.74 KB, image/png)
2010-04-09 09:00 UTC, Anton "Garfeild" Kolchunov 		  Details
Typing tab after patch (23.45 KB, image/png)
2010-04-09 09:01 UTC, Anton "Garfeild" Kolchunov 		  Details
General tab to Typing tab patch (52.57 KB, patch)
2010-04-09 09:03 UTC, Anton "Garfeild" Kolchunov 		needs-work Details | Review

Description Allan Day 2010-04-09 08:45:50 UTC 
A number of UI improvements have been suggested for the General tab. This bug is a tracker for these suggestions.

This bug is a part of the Keyboard Preferences design review which can be found here: http://live.gnome.org/UsabilityProject/Whiteboard/KeyboardPreferences
Comment 1 Anton "Garfeild" Kolchunov 2010-04-09 09:00:58 UTC 
Created attachment 158265 [details]
General tab from git
Comment 2 Anton "Garfeild" Kolchunov 2010-04-09 09:01:36 UTC 
Created attachment 158266 [details]
Typing tab after patch
Comment 3 Anton "Garfeild" Kolchunov 2010-04-09 09:03:47 UTC 
Created attachment 158267 [details] [review]
General tab to Typing tab patch

Greeting!

I have made patch that fixes all dependencies bugs.

Here's screenshots of changes:
GeneralTab.png - screenshot of gnome-keyboard-properties from git;
TypingTab.png - screenshot of gnome-keyboard-properties after my patch.
Comment 4 Jens Granseuer 2010-04-09 17:08:24 UTC 
Comment on attachment 158267 [details] [review]
General tab to Typing tab patch

Thanks!

The key repeat toggle and the blink speed slider no longer seem to have mnemonics, though.

Also, to avoid having to set guards for every single UI element, is it possible to just group all of the elements belonging to one option into a box and simply guard that instead? That would certainly help keep the code tidy.
Comment 5 Anton "Garfeild" Kolchunov 2010-04-09 17:10:51 UTC 
I will remade whole patch, because Allan has changed mockups and requirements for General Tab. 

Thank you for your review!
Comment 6 Bastien Nocera 2011-01-27 15:20:49 UTC 
That's how it looks in GNOME 3 now.