After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 61525 - Button in sobel.c set to wrong state
Button in sobel.c set to wrong state
Status: VERIFIED FIXED
Product: GIMP
Classification: Other
Component: Plugins
1.x
Other All
: Normal normal
: ---
Assigned To: GIMP Bugs
Daniel Egger
Depends on:
Blocks:
 
 
Reported: 2001-10-01 21:39 UTC by floemker
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description floemker 2001-10-01 21:39:18 UTC 
In the sobel plugin the "Keep Sign" button is initially set to the
value of the "Sobel Vertically" button, probably a cut and paste
error. The patch below should fix it.

--- gimp-1.2.2/plug-ins/common/sobel.c.old	Sun Sep 30 22:35:55 2001
+++ gimp-1.2.2/plug-ins/common/sobel.c	Sun Sep 30 22:35:57 2001
@@ -290,7 +290,7 @@
   gtk_signal_connect (GTK_OBJECT (toggle), "toggled",
 		      GTK_SIGNAL_FUNC (gimp_toggle_button_update),
 		      &bvals.keep_sign);
-  gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (toggle),
bvals.vertical);
+  gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (toggle),
bvals.keep_sign);
   gtk_widget_show (toggle);
 
   gtk_widget_show (vbox);
Comment 1 Sven Neumann 2001-10-02 12:01:00 UTC 
I have checked the proposed fix into both the stable and the development
trees. Thanks for the report.

2001-10-02  Sven Neumann  <sven@gimp.org>

  * plug-ins/common/sobel.c (sobel_dialog): corrected initial setting
    of toggle button. Thanks to floemker@TechFak.Uni-Bielefeld.DE for
    spotting this one (bug #61525).
Comment 2 Raphaël Quinet 2001-10-04 16:28:22 UTC 
Marking this bug as RESOLVED FIXED.  It cannot be CLOSED yet because
this patch is not part of an official release.  I will mark this bug
CLOSED as soon as gimp-1.2.3 is released.
Comment 3 Raphaël Quinet 2002-02-12 09:16:19 UTC 
Fix is part of gimp-1.2.3, which has just been released.
Bug is now CLOSED.