After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615242 - Add support for reading/writing replaygain values
Add support for reading/writing replaygain values
Status: RESOLVED WONTFIX
Product: taglib-sharp
Classification: Other
Component: General
unspecified
Other All
: Normal enhancement
: ---
Assigned To: taglib-sharp-maint
taglib-sharp-maint
Depends on:
Blocks: 477351
 
 
Reported: 2010-04-09 00:54 UTC by Gabriel Burt
Modified: 2018-08-17 19:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch partially implementing id3v2 support for rg tags (6.84 KB, patch)
2010-04-09 02:23 UTC, Gabriel Burt
none Details | Review

Description Gabriel Burt 2010-04-09 00:54:50 UTC
It would be good if taglib# supported reading/writing ReplayGain values.  In Banshee, we can use the rganalysis element to get the values, but then we need to save them to the files, and prefer to do that using taglib#.

For id3v2, from http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/tag/gstid3tag.c#n263
  /* foobar2000 uses these identifiers to store gain/peak information in
   * ID3v2 tags <= v2.3.0. In v2.4.0 there's the RVA2 frame for that */
  {GST_TAG_TRACK_GAIN, "TXXX|replaygain_track_gain"},
  {GST_TAG_TRACK_PEAK, "TXXX|replaygain_track_peak"},
  {GST_TAG_ALBUM_GAIN, "TXXX|replaygain_album_gain"},
  {GST_TAG_ALBUM_PEAK, "TXXX|replaygain_album_peak"},

For ogg, from http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/tag/gstvorbistag.c#n69
  {GST_TAG_TRACK_GAIN, "REPLAYGAIN_TRACK_GAIN"},
  {GST_TAG_TRACK_PEAK, "REPLAYGAIN_TRACK_PEAK"},
  {GST_TAG_ALBUM_GAIN, "REPLAYGAIN_ALBUM_GAIN"},
  {GST_TAG_ALBUM_PEAK, "REPLAYGAIN_ALBUM_PEAK"},
  {GST_TAG_REFERENCE_LEVEL, "REPLAYGAIN_REFERENCE_LOUDNESS"},
Comment 1 Alexander Kojevnikov 2010-04-09 00:59:29 UTC
Marking bug 477351 as dependent on this.
Comment 2 Gabriel Burt 2010-04-09 01:41:01 UTC
From http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/replaygain/gstrgvolume.c it looks like all these values are just normal doubles.

We might consider applying these constraints:
0 < peak-values <= 1.0
-60.0 < gain-values < 60.0
Comment 3 Gabriel Burt 2010-04-09 02:12:03 UTC
Info about WAV/RIFF here: http://replaygain.hydrogenaudio.org/file_format_wav.html
Comment 4 Gabriel Burt 2010-04-09 02:23:54 UTC
Created attachment 158250 [details] [review]
patch partially implementing id3v2 support for rg tags

A few caveats:
1) I haven't tested this b/c I haven't found a file with these tags (and mp3gain writes its into into APE tags)
2) That comment above about id3v2.4 having some special tag is not taken into account

Anybody should feel free to take this and run with it - testing/adding ape/ogg/wav/riff etc if you want.  I'll comment here if I plan to work on it again.
Comment 5 Gabriel Burt 2010-04-09 02:31:23 UTC
Info on iTunes' normalization metadata: http://www.id3.org/iTunes_Normalization_settings
Comment 6 André Klapper 2018-08-17 19:48:12 UTC
taglib-sharp has moved to Github a while ago.
Furthermore, GNOME Bugzilla will be shut down and replaced by gitlab.gnome.org.

If the problem reported in this Bugzilla ticket is still valid, please report
it to https://github.com/mono/taglib-sharp/issues instead. Thank you!

Closing this report as WONTFIX as part of Bugzilla Housekeeping.